Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ele 3919 docs fixes #1769

Merged
merged 5 commits into from
Dec 23, 2024
Merged

Conversation

NoyaArie
Copy link
Contributor

No description provided.

Copy link

linear bot commented Dec 23, 2024

- name: null_count
type: null_count
columns: [hello, world]
where_expression: country = 'USA'
cloud_monitored=True

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also this seems invalid YAML

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

- name: null_count
type: null_count
columns: [hello, world]
where_expression: country = 'USA'
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
where_expression: country = 'USA'
where_expression: "country = 'USA'"

@joostboon wdyt?

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👌

@joostboon joostboon merged commit 2679d25 into docs Dec 23, 2024
1 check failed
@joostboon joostboon deleted the ele-3919-metrics-and-alert-rules-docs-fixes branch December 23, 2024 16:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants