Skip to content

Commit

Permalink
Merge pull request #559 from elementary-data/ele-1816-fix-dedup-bug-i…
Browse files Browse the repository at this point in the history
…n-sync

renamed id_column
  • Loading branch information
ofek1weiss authored Sep 28, 2023
2 parents ee9c4c5 + 1acf1ca commit b12fe7b
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 2 deletions.
2 changes: 1 addition & 1 deletion macros/commands/dump_table.sql
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@
{% set column_names = column_names | reject("in", deprecated_column_names) | list %}
{% endif %}

{% set dedup_by_column = node.meta.id_column or "unique_id" %}
{% set dedup_by_column = node.meta.dedup_by_column or "unique_id" %}
{% set order_by_dedup_column = "generated_at" %}
{% set query %}
{% if dedup and (dedup_by_column in column_names) and (order_by_dedup_column in column_names) %}
Expand Down
2 changes: 1 addition & 1 deletion models/edr/dbt_artifacts/dbt_run_results.sql
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@
on_schema_change = 'append_new_columns',
full_refresh=elementary.get_config_var('elementary_full_refresh'),
meta={
"id_column": "model_execution_id",
"dedup_by_column": "model_execution_id",
"timestamp_column": "created_at",
"prev_timestamp_column": "generated_at",
}
Expand Down

0 comments on commit b12fe7b

Please sign in to comment.