bugfixes

elementary-data · Aug 8, 2024 · 6876c21 · 6876c21
1 parent 758f878
commit 6876c21
Show file tree

Hide file tree

Showing 4 changed files with 4 additions and 4 deletions.
diff --git a/macros/edr/metadata_collection/get_metric_properties.sql b/macros/edr/metadata_collection/get_metric_properties.sql
@@ -25,5 +25,5 @@
     {% if collected_by %}
       {% do metric_props.update({'collected_by': collected_by}) %}
     {% endif %}
-    {% do return() %}
+    {% do return(metric_props) %}
 {% endmacro %}
diff --git a/macros/edr/tests/test_collect_metrics.sql b/macros/edr/tests/test_collect_metrics.sql
@@ -7,7 +7,7 @@
     backfill_days=none,
     where_expression=none,
     dimensions=none,
-    cloud_monitored=false           {# Not directly used in the test, read as configuration in Elementary Cloud #}
+    cloud_monitored=false
 ) %}
 
     {{ config(

diff --git a/macros/edr/tests/test_utils/collect_column_metrics.sql b/macros/edr/tests/test_utils/collect_column_metrics.sql
@@ -9,7 +9,7 @@
     backfill_days,
     where_expression,
     dimensions,
-    collected_by=null
+    collected_by=none
 ) %}
     {% set model_graph_node = elementary.get_model_graph_node(model_relation) %}
     {% set metric_props = elementary.get_metric_properties(model_graph_node, timestamp_column, where_expression, time_bucket, dimensions, collected_by=collected_by) %}

diff --git a/macros/edr/tests/test_utils/collect_table_metrics.sql b/macros/edr/tests/test_utils/collect_table_metrics.sql
@@ -8,7 +8,7 @@
     backfill_days,
     where_expression,
     dimensions,
-    collected_by=null
+    collected_by=none
 ) %}
     {% set model_graph_node = elementary.get_model_graph_node(model_relation) %}
     {% set metric_props = elementary.get_metric_properties(model_graph_node, timestamp_column, where_expression, time_bucket, dimensions, collected_by=collected_by) %}