-
Notifications
You must be signed in to change notification settings - Fork 203
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Allow multiple values for SSO attribute_requirements via comma separation #17949
base: develop
Are you sure you want to change the base?
feat: Allow multiple values for SSO attribute_requirements via comma separation #17949
Conversation
bc721c6
to
37c81f6
Compare
37c81f6
to
a6bc148
Compare
a6bc148
to
d83ceeb
Compare
I'm not sure whether the current change is really ideal or whether the JSON schema should be changed to a value list. |
@@ -3380,7 +3381,7 @@ saml2_config: | |||
- attribute: userGroup | |||
value: "staff" | |||
- attribute: department | |||
value: "sales" | |||
value: "sales,admins" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would like to avoid changing the behaviour of existing configuration parameters, and instead introduce new parameters. I'd suggest one_of
, values
or in
value: "sales,admins" | |
one_off: | |
- "sales" | |
- "admins" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code has been adjusted accordingly.
297c68c
to
db1924a
Compare
In the current
attribute_requirements
implementation it is only possible to allow exact matching attribute values. Multiple allowed values for one attribute are not possible as described in #13238.Pull Request Checklist
EventStore
toEventWorkerStore
.".code blocks
.(run the linters)