Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Allow multiple values for SSO attribute_requirements via comma separation #17949

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from

Conversation

meise
Copy link
Contributor

@meise meise commented Nov 20, 2024

In the current attribute_requirements implementation it is only possible to allow exact matching attribute values. Multiple allowed values for one attribute are not possible as described in #13238.

Pull Request Checklist

  • Pull request is based on the develop branch
  • Pull request includes a changelog file. The entry should:
    • Be a short description of your change which makes sense to users. "Fixed a bug that prevented receiving messages from other servers." instead of "Moved X method from EventStore to EventWorkerStore.".
    • Use markdown where necessary, mostly for code blocks.
    • End with either a period (.) or an exclamation mark (!).
    • Start with a capital letter.
    • Feel free to credit yourself, by adding a sentence "Contributed by @github_username." or "Contributed by [Your Name]." to the end of the entry.
  • Code style is correct
    (run the linters)

@meise meise requested a review from a team as a code owner November 20, 2024 17:19
@CLAassistant
Copy link

CLAassistant commented Nov 20, 2024

CLA assistant check
All committers have signed the CLA.

@meise meise force-pushed the 13238_sso_attribute_requirements_multiple_values branch from bc721c6 to 37c81f6 Compare November 20, 2024 17:23
@github-actions github-actions bot deployed to PR Documentation Preview November 20, 2024 17:24 Active
@meise meise changed the title feat: Allow multiple values for SSO attributes via comma separating feat: Allow multiple values for SSO attribute_requirements via comma separating Nov 20, 2024
@meise meise changed the title feat: Allow multiple values for SSO attribute_requirements via comma separating feat: Allow multiple values for SSO attribute_requirements via comma separation Nov 20, 2024
@meise meise force-pushed the 13238_sso_attribute_requirements_multiple_values branch from 37c81f6 to a6bc148 Compare November 20, 2024 17:27
@github-actions github-actions bot deployed to PR Documentation Preview November 20, 2024 17:28 Active
@meise meise force-pushed the 13238_sso_attribute_requirements_multiple_values branch from a6bc148 to d83ceeb Compare November 20, 2024 17:29
@github-actions github-actions bot deployed to PR Documentation Preview November 20, 2024 17:32 Active
@meise
Copy link
Contributor Author

meise commented Nov 20, 2024

I'm not sure whether the current change is really ideal or whether the JSON schema should be changed to a value list.

@@ -3380,7 +3381,7 @@ saml2_config:
- attribute: userGroup
value: "staff"
- attribute: department
value: "sales"
value: "sales,admins"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would like to avoid changing the behaviour of existing configuration parameters, and instead introduce new parameters. I'd suggest one_of, values or in

Suggested change
value: "sales,admins"
one_off:
- "sales"
- "admins"

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code has been adjusted accordingly.

@pizkaz pizkaz force-pushed the 13238_sso_attribute_requirements_multiple_values branch from 297c68c to db1924a Compare November 21, 2024 20:17
@meise meise requested a review from sandhose November 21, 2024 20:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants