-
Notifications
You must be signed in to change notification settings - Fork 113
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add voice message rendering to the timeline #1776
Conversation
Generated by 🚫 Danger Swift against b617ee9 |
ElementX/Sources/Screens/RoomScreen/View/Style/LongPressWithFeedback.swift
Show resolved
Hide resolved
...ces/Services/Timeline/TimelineItems/Items/Messages/VoiceMessages/VoiceRoomPlaybackView.swift
Outdated
Show resolved
Hide resolved
...ervices/Timeline/TimelineItems/Items/Messages/VoiceMessages/VoiceRoomPlaybackViewState.swift
Outdated
Show resolved
Hide resolved
...ces/Services/Timeline/TimelineItems/Items/Messages/VoiceMessages/VoiceRoomTimelineView.swift
Outdated
Show resolved
Hide resolved
...entX/Sources/Services/Timeline/TimelineItems/Items/Messages/VoiceMessages/WaveformView.swift
Outdated
Show resolved
Hide resolved
ElementX/Sources/Screens/RoomScreen/View/Style/TimelineItemBubbledStylerView.swift
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, however I would check if the audio message supports replies and thread decorators correctly, also need to add all the screens to the preview tests
…nd TimelineItemPlainStylerView
004d070
to
b617ee9
Compare
Kudos, SonarCloud Quality Gate passed! 0 Bugs No Coverage information |
This PR adds:
voiceMessageEnabled
The
LongPressViewFeedback
modifier has been slightly updated to allow the long press action to be disabled for a specific timeline item, so the drag gesture on the waveform can be performed without triggering the standard long press gesture action.