Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Historic messages decrypt on cache reloading, but not before #3055

Closed
wrjlewis opened this issue Jul 17, 2024 · 15 comments
Closed

Historic messages decrypt on cache reloading, but not before #3055

wrjlewis opened this issue Jul 17, 2024 · 15 comments
Assignees
Labels
A-E2EE Encryption O-Occasional Affects or can be seen by some users regularly or most users rarely S-Major Severely degrades major functionality or product features, with no satisfactory workaround T-Defect X-Release-Blocker

Comments

@wrjlewis
Copy link

Steps to reproduce

Sign into a new instance of Element X
Verify your device
Open some chats with historic E2EE message, those messages can appear as UTDs
Clear EX cache in developer settings
All historic messages are now decrypted properly

Outcome

What did you expect?

Historic messages decrypt successfully, and are displayed as such, without having to cache reload.

What happened instead?

Historic messages that are shown as UTDs in the timeline seem stuck that way indefinitely. It could be that the keys are being downloaded or processed at the same time as a user trying to open the message, EX is unable to show the message and presents it as a UTD, and subsequently doesn't attempt to decrypt the message again in future.

Your phone model

iPhone 12 pro

Operating system version

MacOS and iOS

Application version

1.6.13

Homeserver

Synapse

Will you send logs?

No

@pixlwave
Copy link
Member

This sounds like it might be similar to #3045 but viewed from a different perspective.

@wrjlewis
Copy link
Author

This sounds like it might be similar to #3045 but viewed from a different perspective.

Yup sounds similar - ie EX caching the fact it's not immediately been able to decrypt the event

@ara4n
Copy link
Member

ara4n commented Jul 23, 2024

Getting similar on EXA too: element-hq/element-x-android#3234

@Velin92 Velin92 added A-E2EE Encryption S-Major Severely degrades major functionality or product features, with no satisfactory workaround O-Occasional Affects or can be seen by some users regularly or most users rarely labels Jul 24, 2024
@richvdh
Copy link
Member

richvdh commented Jul 26, 2024

Since this seems common to EXI and EXA, and likely a problem in the rust layer, I have pulled out a common issue to track fixing this in the rust layer: matrix-org/matrix-rust-sdk#3768

@wrjlewis
Copy link
Author

Still seeing this, as are others I know running EX, consistently.
@neilisfragile ran into this on Friday on switchover to SSS which forces a logout / login.

@richvdh
Copy link
Member

richvdh commented Aug 19, 2024

Please do send rageshakes for any observed UTDs. Our decisions for which UTD causes get fixed are pretty directly based on the number of rageshakes we see for those causes.

@neilisfragile
Copy link
Member

Here is a rageshake, though I (and I think anyone) can consistently reproduce.
https://github.com/element-hq/element-x-ios-rageshakes/issues/2088

@ara4n
Copy link
Member

ara4n commented Sep 2, 2024

i wonder if this is the same as #2417.

It might also be happening on EXA in element-hq/element-x-android#3382

@thibaultamartin
Copy link

Happening to me as well on Element X nightly, after turning "Force Native Sync" and logging out and back in. The suggested workaround to clear the cache fixes things. Happy to test again once there is a fix in EX

@pixlwave
Copy link
Member

pixlwave commented Sep 9, 2024

I saw the same thing on migrating my personal account to SSS and logged in/out multiple times wondering if cross-signing was broken. A force quit worked for me rather than clearing the cache.

@poljar
Copy link
Contributor

poljar commented Sep 9, 2024

As matrix-org/matrix-rust-sdk#3964 has been closed, this should be done, I'll leave this issue open until there's a EX-iOS release confirming this.

@pixlwave
Copy link
Member

Ok nice, #3215 includes an SDK update with that PR.

@manuroe
Copy link
Member

manuroe commented Sep 11, 2024

@pixlwave can you verify it is fixed in the EXI app?

@pixlwave
Copy link
Member

I can confirm, this is working now:

backup.mp4

@richvdh
Copy link
Member

richvdh commented Dec 18, 2024

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-E2EE Encryption O-Occasional Affects or can be seen by some users regularly or most users rarely S-Major Severely degrades major functionality or product features, with no satisfactory workaround T-Defect X-Release-Blocker
Projects
None yet
Development

No branches or pull requests

9 participants