Retry the decryption of events in the timeline if backups were enabled #3964
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3964 +/- ##
==========================================
+ Coverage 84.16% 84.28% +0.12%
==========================================
Files 267 267
Lines 28190 28211 +21
==========================================
+ Hits 23725 23778 +53
+ Misses 4465 4433 -32 ☔ View full report in Codecov by Sentry. |
Hywan
approved these changes
Sep 9, 2024
The term session is usually only used in the crypto crate to reference a Megolm session, the rest of the SDK uses the name from the event and the Matrix spec, this should lower the amount of confusion since the main crate has already a session concept and its unrelated to end-to-end encryption.
poljar
force-pushed
the
poljar/timeline-retry-decryption-if-backups-enable
branch
from
b4886ae to
7df2329
Compare
poljar
deleted the
poljar/timeline-retry-decryption-if-backups-enable
branch
This was referenced Sep 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is an attempt to fix #3768 and subsequently element-hq/element-x-ios#3055. A review commit by commit is advised.
There are two issues that I have discovered:
The first two commits add regression tests for these two issues, then we fix the actual issues, and lastly we address a TODO item in the vicinity of the room key download task, and do some renames.
If this is too much to handle, please feel free to push for separate PRs for these tasks.
This closes: #3768.