Show who voted for what in poll results

[timvahlbrock]

Checklist

• Tests written for new code (and old code if feasible).
• New or updated public/exported symbols have accurate TSDoc documentation. not applicable
• Linter and other CI checks pass.
• I have licensed the changes to Element by completing the Contributor License Agreement (CLA)

Closes #28488

[CLAassistant]

All committers have signed the CLA.

[timvahlbrock]

I tried to create tests as well for whether the face pile on the poll options is hidden when the room has more than five members, but I found it very hard to do without relying much on implementation detail.

[timvahlbrock]

I'm also open for other approaches to opening the detailed result list. One idea might be to make a separate, underlined span that just says "Open full results" next to it.

[timvahlbrock]

Strict mode commit was temporarily reverted because of #28306

[timvahlbrock]

Also found the time to add an end to end test for the vote results dialog. If there is anything else that I can do to progress this PR further, please let me know.

[dbkr]

I see this has been sent to design & product for review, but I'm not really sure what this PR is trying to do. A description, linked bug and screenshot would help.

That said, I suspect the answer from product will be that polls need to stay consistent between clients, so if this makes web display more than Element X, we'd also need to make corresponding changes there and land them around the same time.

[timvahlbrock]

I see this has been sent to design & product for review, but I'm not really sure what this PR is trying to do. A description, linked bug and screenshot would help.

Oh sure. Damn I wanted to do that but forgot it again. Will do.

That said, I suspect the answer from product will be that polls need to stay consistent between clients, so if this makes web display more than Element X, we'd also need to make corresponding changes there and land them around the same time.

Okay. I will take a look if I can manage to do that.

[timvahlbrock]

Screenshots from the End to End Tests:

Before:

After:

[dbkr]

Thanks, so this isn't actually as big a change as I'd guessed. Maybe this would be fine to land without a corresponding Element X change.

[timvahlbrock]

Thanks, so this isn't actually as big a change as I'd guessed. Maybe this would be fine to land without a corresponding Element X change.

Yeah, if not, maybe it would be sufficient to show a text on element x like "Users on other platforms may see what you voted for", while the feature hasn't been implemented yet.

[timvahlbrock]

Alternative Design Proposal: using a button instead of clickable text, somewhat like this: