Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Solid Counter #121

Merged
merged 7 commits into from
Nov 18, 2024
Merged

Solid Counter #121

merged 7 commits into from
Nov 18, 2024

Conversation

Velin92
Copy link
Member

@Velin92 Velin92 commented Nov 18, 2024

Check also the snapshot tests here:
element-hq/compound-ios-snapshots#2

@Velin92 Velin92 requested a review from a team as a code owner November 18, 2024 12:45
@Velin92 Velin92 requested review from pixlwave and removed request for a team November 18, 2024 12:45
Copy link

codecov bot commented Nov 18, 2024

Codecov Report

Attention: Patch coverage is 82.97872% with 8 lines in your changes missing coverage. Please review.

Project coverage is 96.48%. Comparing base (4af4155) to head (0443e43).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
Sources/Compound/List/ListRowDetails.swift 73.33% 8 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #121      +/-   ##
==========================================
- Coverage   96.78%   96.48%   -0.30%     
==========================================
  Files          19       19              
  Lines        1274     1309      +35     
==========================================
+ Hits         1233     1263      +30     
- Misses         41       46       +5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@pixlwave pixlwave left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, just one public API change and then we're good to go 👌

Sources/Compound/List/ListRowTrailingSection.swift Outdated Show resolved Hide resolved
Sources/Compound/List/ListRowDetails.swift Outdated Show resolved Hide resolved
Copy link
Member

@pixlwave pixlwave left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks 👏

@Velin92 Velin92 merged commit 15efda7 into main Nov 18, 2024
2 checks passed
@Velin92 Velin92 deleted the mauroromito/list_row_details_badge branch November 18, 2024 13:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants