Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: icon in Apps & Features is wrong #523

Closed

Conversation

bdaileyumich
Copy link

use user-specified setupIcon as app icon when applicable, else fall back to electron icon

@bdaileyumich bdaileyumich requested a review from a team as a code owner July 11, 2024 15:56
@BlackHole1
Copy link
Member

BlackHole1 commented Jul 12, 2024

Thank you for your contribution!

However, regarding this PR, I do not see any practical effect. Users can specify the iconUrl in options or package.json. See:

Object.assign(metadata, {
exe: `${appMetadata.name}.exe`,
title: appMetadata.productName || appMetadata.name
}, appMetadata);
}
Object.assign(metadata, options);

What you have modified is just a default value.

So I will close this PR, if you have any other comments, I can reopen this PR :)

@BlackHole1 BlackHole1 closed this Jul 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants