Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Handle all 64 bits architecture and rcedit-x64 while using wine #380

Closed
wants to merge 2 commits into from
Closed

fix: Handle all 64 bits architecture and rcedit-x64 while using wine #380

wants to merge 2 commits into from

Conversation

nullxx
Copy link

@nullxx nullxx commented Apr 1, 2021

No description provided.

@nullxx nullxx changed the title Handle all 64 bits architecture and rcedit-x64 while using wine fix: Handle all 64 bits architecture and rcedit-x64 while using wine Apr 1, 2021
@dsanders11 dsanders11 mentioned this pull request Nov 8, 2023
Merged
@dsanders11
Copy link
Member

Thank you for this PR, sorry it took us so long to get to. I've opened #493 to fix the wine64 bit, but I don't think the rcedit fix you've included is the right way to go. We should update this codebase to use the rcedit package rather than vendoring rcedit executable files, but that will require some further changes. As such I'm going to close out this PR.

@dsanders11 dsanders11 closed this Nov 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@dsanders11 dsanders11

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nullxx @dsanders11