Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: enable i18n #78

Closed
wants to merge 5 commits into from
Closed

feat: enable i18n #78

wants to merge 5 commits into from

Conversation

molant
Copy link
Contributor

@molant molant commented Jul 21, 2021

Integrate with Crowdin to download the latest translations and generate
the site for the supported locales.


Fix #64

@MarshallOfSound MarshallOfSound temporarily deployed to electronjsorg-new-pr-78 July 21, 2021 22:40 Inactive
@molant
Copy link
Contributor Author

molant commented Jul 21, 2021

This supersedes #64 and should be easier to review.

@molant molant requested review from erickzhao and ckerr July 21, 2021 22:40
@molant molant had a problem deploying to electronjsorg-new-pr-78 July 21, 2021 22:44 Failure
@molant molant temporarily deployed to electronjsorg-new-pr-78 July 21, 2021 22:44 Inactive
@molant molant temporarily deployed to electronjsorg-new-pr-78 July 21, 2021 23:30 Inactive
Copy link
Member

@ckerr ckerr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I had a few questions inline -- some were optional changes, some were just questions I had to get familiar with the code -- but overall LGTM. No blockers.

const path = require('path');
const { existsSync } = require('fs');
const fs = require('fs-extra');
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

out-of-scope for this PR, but if adding fs-extra, the del dependency can be removed

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I need to review when I'm deleting folders. I know that I liked it because it accepts globby patterns and then I could use .gitignore to clean all the files in the prebuild step but in this new PR it might not be needed.

scripts/pre-build.js Show resolved Hide resolved
scripts/pre-build.js Show resolved Hide resolved
scripts/tasks/download-translations.js Outdated Show resolved Hide resolved
scripts/tasks/download-translations.js Show resolved Hide resolved
scripts/tasks/md-fixers.js Show resolved Hide resolved
@MarshallOfSound MarshallOfSound temporarily deployed to electronjsorg-new-pr-78 July 23, 2021 18:33 Inactive
@molant molant temporarily deployed to electronjsorg-new-pr-78 July 23, 2021 21:43 Inactive
@molant
Copy link
Contributor Author

molant commented Jul 23, 2021

The current build failures on Heroku are because of incorrect markdown being downloaded from Crowdin. I'll try to fix all of those before I'm on vacation 🏖

@molant molant temporarily deployed to electronjsorg-new-pr-78 July 23, 2021 21:59 Inactive
@molant molant temporarily deployed to electronjsorg-new-pr-78 July 23, 2021 22:31 Inactive
@molant molant temporarily deployed to electronjsorg-new-pr-78 July 24, 2021 14:43 Inactive
@molant molant temporarily deployed to electronjsorg-new-pr-78 July 24, 2021 15:20 Inactive
@molant molant temporarily deployed to electronjsorg-new-pr-78 July 24, 2021 16:45 Inactive
@molant molant temporarily deployed to electronjsorg-new-pr-78 July 24, 2021 17:10 Inactive
@molant molant temporarily deployed to electronjsorg-new-pr-78 July 24, 2021 17:47 Inactive
@molant molant temporarily deployed to electronjsorg-new-pr-78 July 24, 2021 18:24 Inactive
@molant molant temporarily deployed to electronjsorg-new-pr-78 July 24, 2021 19:30 Inactive
@molant
Copy link
Contributor Author

molant commented Jul 24, 2021

Build is failing now with the following message 😭

<--- Last few GCs --->
[4227:0x5f7aa80]  2083570 ms: Scavenge 2500.6 (2581.1) -> 2489.8 (2581.6) MB, 21.5 / 0.0 ms  (average mu = 0.315, current mu = 0.348) allocation failure 
[4227:0x5f7aa80]  2083755 ms: Scavenge 2503.7 (2581.6) -> 2493.1 (2582.6) MB, 24.5 / 0.0 ms  (average mu = 0.315, current mu = 0.348) allocation failure 
[4227:0x5f7aa80]  2087361 ms: Mark-sweep 2506.1 (2582.6) -> 2474.2 (2581.8) MB, 3465.3 / 0.1 ms  (average mu = 0.335, current mu = 0.354) allocation failure scavenge might not succeed
<--- JS stacktrace --->
FATAL ERROR: Ineffective mark-compacts near heap limit Allocation failed - JavaScript heap out of memory
 1: 0xa24ed0 node::Abort() [/tmp/build_36b48d1b/.heroku/node/bin/node]
 2: 0x966115 node::FatalError(char const*, char const*) [/tmp/build_36b48d1b/.heroku/node/bin/node]
 3: 0xb9acde v8::Utils::ReportOOMFailure(v8::internal::Isolate*, char const*, bool) [/tmp/build_36b48d1b/.heroku/node/bin/node]
 4: 0xb9b057 v8::internal::V8::FatalProcessOutOfMemory(v8::internal::Isolate*, char const*, bool) [/tmp/build_36b48d1b/.heroku/node/bin/node]
 5: 0xd56ea5  [/tmp/build_36b48d1b/.heroku/node/bin/node]
 6: 0xd57a2f  [/tmp/build_36b48d1b/.heroku/node/bin/node]
 7: 0xd65abb v8::internal::Heap::CollectGarbage(v8::internal::AllocationSpace, v8::internal::GarbageCollectionReason, v8::GCCallbackFlags) [/tmp/build_36b48d1b/.heroku/node/bin/node]
 8: 0xd6967c v8::internal::Heap::AllocateRawWithRetryOrFailSlowPath(int, v8::internal::AllocationType, v8::internal::AllocationOrigin, v8::internal::AllocationAlignment) [/tmp/build_36b48d1b/.heroku/node/bin/node]
 9: 0xd37d2b v8::internal::Factory::NewFillerObject(int, bool, v8::internal::AllocationType, v8::internal::AllocationOrigin) [/tmp/build_36b48d1b/.heroku/node/bin/node]
10: 0x108035f v8::internal::Runtime_AllocateInYoungGeneration(int, unsigned long*, v8::internal::Isolate*) [/tmp/build_36b48d1b/.heroku/node/bin/node]
11: 0x1427079  [/tmp/build_36b48d1b/.heroku/node/bin/node]
Aborted
error Command failed with exit code 134.

@molant
Copy link
Contributor Author

molant commented Jul 24, 2021

We might need to build the languages one by one. There might be some leaking using the regular build command 🤔
Also the build takes forever (5-6min per language).

@molant molant temporarily deployed to electronjsorg-new-pr-78 September 30, 2021 02:56 Inactive
@molant molant mentioned this pull request Sep 30, 2021
4 tasks
molant added 2 commits October 4, 2021 14:12
Integrate with Crowdin to download the latest translations and generate
the site for the supported locales.

- - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - -

Fix #64
@molant molant temporarily deployed to electronjsorg-new-pr-78 October 4, 2021 21:17 Inactive
@MarshallOfSound MarshallOfSound temporarily deployed to electronjsorg-new-pr-78 October 4, 2021 21:30 Inactive
@MarshallOfSound MarshallOfSound temporarily deployed to electronjsorg-new-pr-78 October 4, 2021 21:40 Inactive
@molant molant temporarily deployed to electronjsorg-new-pr-78 October 4, 2021 22:47 Inactive
@molant molant mentioned this pull request Oct 7, 2021
@molant
Copy link
Contributor Author

molant commented Oct 7, 2021

Closing in favor of #112

@molant molant closed this Oct 7, 2021
@molant molant deleted the feat/i18n branch October 20, 2021 22:16
Copy link

cloudflare-workers-and-pages bot commented Sep 6, 2024

Deploying electron-website with  Cloudflare Pages  Cloudflare Pages

Latest commit: 3f1b2c0
Status: ✅  Deploy successful!
Preview URL: https://feb04980.electron-website.pages.dev
Branch Preview URL: https://chore-i18n-build-paralleliza.electron-website.pages.dev

View logs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Internationalization
3 participants