-
Notifications
You must be signed in to change notification settings - Fork 141
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: enable i18n #78
Conversation
This supersedes #64 and should be easier to review. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I had a few questions inline -- some were optional changes, some were just questions I had to get familiar with the code -- but overall LGTM. No blockers.
const path = require('path'); | ||
const { existsSync } = require('fs'); | ||
const fs = require('fs-extra'); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
out-of-scope for this PR, but if adding fs-extra, the del dependency can be removed
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I need to review when I'm deleting folders. I know that I liked it because it accepts globby patterns and then I could use .gitignore
to clean all the files in the prebuild step but in this new PR it might not be needed.
The current build failures on Heroku are because of incorrect markdown being downloaded from Crowdin. I'll try to fix all of those before I'm on vacation 🏖 |
Build is failing now with the following message 😭
|
We might need to build the languages one by one. There might be some leaking using the regular |
Integrate with Crowdin to download the latest translations and generate the site for the supported locales. - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - Fix #64
Closing in favor of #112 |
Deploying electron-website with Cloudflare Pages
|
Integrate with Crowdin to download the latest translations and generate
the site for the supported locales.
Fix #64