feat: enable docsearch #22
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Enable docsearch module with provided configuration by algolia. Currently the search does not seem to work when `contextSearch` is enabled. This seems to be a temporary issue per Clement's mail: > As the DocSearch plugin is not active yet, you won't be able to use the Docusaurus `contextualSearch` option until next crawl. While this feature is not necessary (there are no versioned docs), it seems like the search results page has it enabled by default always ([1]) so might as well have it enabled everywhere to make sure it works. - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - [1]: https://github.com/temporalio/documentation/pull/357/files#r616656533 Ref: facebook/docusaurus#3805 Part of #2
|
This is how it looks like when disabling The results page is empty:
Before merging this we need to make sure that |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enable docsearch module with provided configuration by algolia.
Currently the search does not seem to work when
contextSearchisenabled. This seems to be a temporary issue per Clement's mail:
While this feature is not necessary (there are no versioned docs),
it seems like the search results page has it enabled by default
always (1) so might as well have it enabled everywhere to make sure it
works.
Ref: facebook/docusaurus#3805
Part of #2