This repository has been archived by the owner on Aug 11, 2022. It is now read-only.
test: update values for new Crowdin URLs #1985
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
erickzhao
approved these changes
Jul 15, 2021
vhashimotoo
commented
Jul 15, 2021
| it('contains localized strings', () => { | ||
| // FIXME: This test should work and the Russian string should return but after #1983 these Russian string have been fallen back to English. | ||
| // Please verify that test passed after some time. | ||
| it.skip('contains localized strings', () => { | ||
| i18n.website['en-US'].tagline.should.contain('desktop apps') | ||
| i18n.website['ru-RU'].tagline.should.contain( |
There was a problem hiding this comment.
This string is translated on Crowdin, but on the GH side, the major amount of strings have been fallen back to their English version.
| @@ -214,7 +216,7 @@ describe('API Structures', () => { | |||
|
|
|||
| it('sets expected crowdinFileId', () => { | |||
| const doc = i18n.docs['fr-FR']['/docs/api/structures/gpu-feature-status'] | |||
| doc.crowdinFileId.should.equal('250646') | |||
| doc.crowdinFileId.should.equal('255810') | |||
There was a problem hiding this comment.
It's probably due to that #1982 added new files
|
🎉 This PR is included in version 1.3083.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.