Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: use streaming I/O to avoid reading entire binary into memory #34

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

eeror
Copy link

@eeror eeror commented Feb 29, 2024

Some debug builds can be large enough to make it prohibitive to read the entire Electron binary into memory in some CI environments.

This PR adds the machinery needed to:

  • look for fuse wires in a file stream, and
  • only overwrite the fuse wire bytes instead of the entire binary.

@eeror eeror requested a review from a team as a code owner February 29, 2024 07:36
@dsanders11 dsanders11 self-assigned this Feb 29, 2024
@dsanders11 dsanders11 changed the title Implement streaming I/O to avoid reading the entire binary into memory feat: use streaming I/O to avoid reading entire binary into memory Mar 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants