fix: cscIKeyPassword must support empty string arguments (#8653)

electron-userland · Nov 1, 2024 · 796e1a0 · 796e1a0
1 parent f84a083
commit 796e1a0
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 1 deletion.
diff --git a/.changeset/fresh-camels-smash.md b/.changeset/fresh-camels-smash.md
@@ -0,0 +1,5 @@
+---
+"app-builder-lib": patch
+---
+
+fix: cscIKeyPassword must support empty string arguments
diff --git a/packages/app-builder-lib/src/codeSign/macCodeSign.ts b/packages/app-builder-lib/src/codeSign/macCodeSign.ts
@@ -198,7 +198,7 @@ export async function createKeychain({ tmpDir, cscLink, cscKeyPassword, cscILink
     BluebirdPromise.mapSeries(securityCommands, it => exec("/usr/bin/security", it)),
   ])
   const cscPasswords: Array<string> = [cscKeyPassword]
-  if (cscIKeyPassword) {
+  if (cscIKeyPassword != null) {
     cscPasswords.push(cscIKeyPassword)
   }
   return await importCerts(keychainFile, certPaths, cscPasswords)