Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Increase timeout for docs PR link action #16718

Merged
merged 2 commits into from
Nov 22, 2024
Merged

Increase timeout for docs PR link action #16718

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8144ba8
Increase timeout for docs PR link action
robbavey Nov 21, 2024
6c2d130
Cleanup comments
robbavey Nov 21, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions .github/workflows/add-docs-preview-link.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,9 +20,9 @@ jobs:
# when running with on: pull_request_target we get the PR base ref by default
ref: ${{ github.event.pull_request.head.sha }}
statusName: "buildkite/docs-build-pr"
# https://elasticsearch-ci.elastic.co/job/elastic+logstash+pull-request+build-docs
# https://buildkite.com/elastic/docs-build-pr/builds?meta_data[repo_pr]=${REPO}_${PR}
# usually finishes in ~ 20 minutes
timeoutSeconds: 900
timeoutSeconds: 1800
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The comment and original value dont really make sense? If it typically finishes in ~20 minutes, why would the timeout be 15 minutes? Also, the URI in the comment does not seem to be correct either. I'm assuming this is somehow tracking the buildkite job? The github action history make it look like this just always goes for about 15 minutes (the timeout threshold) but it looks like buildkite jobs can finish much fater than that https://buildkite.com/elastic/docs-build-pr/builds/194330 for example?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the root of my misunderstanding here is what this is meant to track and how to validate that status

logstash/.github/workflows/add-docs-preview-link.yml

Line 22 in eb7e125

statusName: "buildkite/docs-build-pr"

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let me clear up the comments - there are a bunch of mixed messages here from previous commits.

The builds take ~ 20 minutes, so the 30 minute timeout should be sufficient.

It took me a little digging to find the right incantation to find product specific builds - the latest one for example is https://buildkite.com/elastic/docs-build-pr/builds?created_from_days=7&meta_data%5Brepo_pr%5D=logstash_16701

intervalSeconds: 30
- name: Add Docs Preview link in PR Comment
if: steps.wait-for-status.outputs.state == 'success'
Expand Down