Forwardport PR #16671 to main: PipelineBusV2 deadlock proofing #16682
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
yaauie
changed the title
donoghuc
approved these changes
Nov 19, 2024
There was a problem hiding this comment.
CI failure unrelated. Filed https://github.com/elastic/logstash/pull/16695/files to address that. This port is clean and ready to go.
* pipeline bus: add deadlock test for unlisten/unregisterSender * pipeline bus: eliminate deadlock Moves the sync-to-notify out of the `AddressStateMapping#mutate`'s effective synchronous block to eliminate a race condition where unlistening to an address and unregistering a sender could deadlock. It is safe to notify an AddressState's attached input without exclusive access to the AddressState, because notifying an input that has since been disconnected is net zero harm. (cherry picked from commit 8af6343)
jsvd
force-pushed
the
backport_16671_main
branch
from
d5d2876
to
039a4d8
Compare
|
I've rebased the PR against main, should be green soon. |
|
Ah, I was just about to ask about that. I had tried to reload the failed cell thinking maybe it would try to test changes against the current head of main. Seems like instead it just tests based on the head of the branch being tested. |
|
💚 Build Succeeded
History
|
|
🍏 🟢 💚 📗 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Forwardport PR #16671 to main branch, original message:
Release notes
What does this PR do?
PipelineBus#unlistenandPipelineBus#unregisterSenderPipelineBusV2Why is it important/What is the impact to the user?
Failing to shut down is not good.
Checklist
[ ] I have made corresponding changes to the documentation[ ] I have made corresponding change to the default configuration files (and/or docker env variables)How to test this PR locally
Related issues