Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[8.x] [ES|QL] Fixes the multiple comments bug (#203966) #204002

Merged
merged 1 commit into from
Dec 12, 2024

Conversation

kibanamachine
Copy link
Contributor

Backport

This will backport the following commits from main to 8.x:

Questions ?

Please refer to the Backport tool documentation

## Summary

![meow](https://github.com/user-attachments/assets/aea64a3c-97de-417a-bd67-5434e70cf22a)

Sometimes commenting multiple lines doesnt work as expected.

This PR fixes it. The problem was that we were (un)commenting line by
line and this apparently can be buggy. With this PR we gather the edits
and apply all of them in one `executeEdits `

(cherry picked from commit 9edadfd)
@kibanamachine kibanamachine merged commit 10e01b4 into elastic:8.x Dec 12, 2024
11 checks passed
@elasticmachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
esql 202.7KB 202.7KB +18.0B

cc @stratoula

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants