-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Observability AI Assistant] fix: Improve tool choice handling in Observability AI Assistant client #203928
[Observability AI Assistant] fix: Improve tool choice handling in Observability AI Assistant client #203928
Conversation
Pinging @elastic/obs-ai-assistant (Team:Obs AI Assistant) |
🤖 GitHub commentsExpand to view the GitHub comments
Just comment with:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Added a couple of comments (nitpicks).
x-pack/plugins/observability_solution/observability_ai_assistant/server/service/client/index.ts
Outdated
Show resolved
Hide resolved
x-pack/plugins/observability_solution/observability_ai_assistant/server/service/client/index.ts
Outdated
Show resolved
Hide resolved
Co-authored-by: Viduni Wickramarachchi <[email protected]>
ee1ca19
to
fd69535
Compare
💛 Build succeeded, but was flaky
Failed CI StepsTest Failures
Metrics [docs]
History
|
Starting backport for target branches: 8.x |
…ervability AI Assistant client (elastic#203928) Error: https://github.com/user-attachments/assets/3ada87df-9c60-4916-aa5a-7f95fb2dc275 logs: ``` bash [2024-12-11T11:03:19.666-05:00][WARN ][plugins.actions.gen-ai] action execution failure: .gen-ai:azure-gpt4: GPT-4 Azure: an error occurred while running the action: Status code: 400. Message: API Error: #model_error - [] should be non-empty - 'tools'; retry: true [2024-12-11T11:03:19.669-05:00][ERROR][plugins.observabilityAIAssistant.service] Error: Unexpected error at createInferenceInternalError (/Users/viduni/Workspace/Elastic/kibana/x-pack/packages/ai-infra/inference-common/src/errors.ts:49:10 ``` --------- Co-authored-by: Viduni Wickramarachchi <[email protected]> (cherry picked from commit 4455087)
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
Closes #203926 |
Closes #203926
Error:
ai_assistant_broken.mov
logs:
Checklist
Check the PR satisfies following conditions.
Reviewers should verify this PR satisfies this list as well.
release_note:breaking
label should be applied in these situations.release_note:*
label is applied per the guidelinesIdentify risks
Does this PR introduce any risks? For example, consider risks like hard to test bugs, performance regression, potential of data loss.
Describe the risk, its severity, and mitigation for each identified risk. Invite stakeholders and evaluate how to proceed before merging.