Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[embeddable] remove reactEmbeddableRegistryHasKey from start API #203673

Merged
merged 4 commits into from
Dec 11, 2024
Merged

[embeddable] remove reactEmbeddableRegistryHasKey from start API #203673

merged 4 commits into from
Dec 11, 2024
+3 −40

Conversation

nreese
Copy link
Contributor

@nreese nreese commented Dec 10, 2024 •
edited by kibanamachine
Loading

Closes #203250

@nreese
Copy link
Contributor Author

nreese commented Dec 10, 2024

@elasticmachine merge upstream

@nreese
Copy link
Contributor Author

nreese commented Dec 10, 2024

/ci

@nreese
Copy link
Contributor Author

nreese commented Dec 10, 2024

/ci

@elasticmachine
Copy link
Contributor

💛 Build succeeded, but was flaky

Failed CI Steps

Test Failures

  • [job] [logs] Jest Tests #12 / UserName should open expandable flyout on table

Metrics [docs]

Public APIs missing comments

Total count of every public API that lacks a comment. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats comments for more detailed information.

id before after diff
embeddable 458 457 -1

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
embeddable 71.0KB 70.6KB -400.0B
Unknown metric groups

API count

id before after diff
embeddable 564 562 -2

History

@nreese nreese marked this pull request as ready for review December 10, 2024 23:54
@nreese nreese requested a review from a team as a code owner December 10, 2024 23:54
@nreese nreese added Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas release_note:skip Skip the PR/issue when compiling release notes v9.0.0 project:embeddableRebuild backport:version Backport to applied version labels v8.18.0 labels Dec 10, 2024
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-presentation (Team:Presentation)

@botelastic botelastic bot added the Feature:Embedding Embedding content via iFrame label Dec 11, 2024
@nreese nreese merged commit 7b9dd35 into elastic:main Dec 11, 2024
22 checks passed
@kibanamachine
Copy link
Contributor

Starting backport for target branches: 8.x

https://github.com/elastic/kibana/actions/runs/12284314916

kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Dec 11, 2024
@nreese
[embeddable] remove reactEmbeddableRegistryHasKey from start API (ela…
014554c 
…stic#203673)

Closes elastic#203250

---------

Co-authored-by: Elastic Machine <[email protected]>
Co-authored-by: kibanamachine <[email protected]>
(cherry picked from commit 7b9dd35)
@nreese nreese mentioned this pull request Dec 12, 2024
Merged
@nreese
Copy link
Contributor Author

nreese commented Dec 12, 2024

💚 All backports created successfully

Status Branch Result
✅ 8.x

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

nreese added a commit to nreese/kibana that referenced this pull request Dec 12, 2024
@nreese
[embeddable] remove reactEmbeddableRegistryHasKey from start API (ela…
68ae377 
…stic#203673)

Closes elastic#203250

---------

Co-authored-by: Elastic Machine <[email protected]>
Co-authored-by: kibanamachine <[email protected]>
(cherry picked from commit 7b9dd35)
CAWilson94 pushed a commit to CAWilson94/kibana that referenced this pull request Dec 12, 2024
@nreese @elasticmachine
@kibanamachine @CAWilson94
[embeddable] remove reactEmbeddableRegistryHasKey from start API (ela…
9b255ae 
…stic#203673)

Closes elastic#203250

---------

Co-authored-by: Elastic Machine <[email protected]>
Co-authored-by: kibanamachine <[email protected]>
nreese added a commit that referenced this pull request Dec 12, 2024
@nreese @elasticmachine
[8.x] [embeddable] remove reactEmbeddableRegistryHasKey from start API (
acefaf4 
#203673) (#203951)

# Backport

This will backport the following commits from `main` to `8.x`:
- [[embeddable] remove reactEmbeddableRegistryHasKey from start API
(#203673)](#203673)

<!--- Backport version: 8.9.8 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Nathan
Reese","email":"[email protected]"},"sourceCommit":{"committedDate":"2024-12-11T20:25:21Z","message":"[embeddable]
remove reactEmbeddableRegistryHasKey from start API (#203673)\n\nCloses
https://github.com/elastic/kibana/issues/203250\r\n\r\n---------\r\n\r\nCo-authored-by:
Elastic Machine
<[email protected]>\r\nCo-authored-by:
kibanamachine
<[email protected]>","sha":"7b9dd357ef568f25427b7bf70fa00e057f952c05","branchLabelMapping":{"^v9.0.0$":"main","^v8.18.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["Feature:Embedding","Team:Presentation","release_note:skip","v9.0.0","project:embeddableRebuild","backport:version","v8.18.0"],"number":203673,"url":"https://github.com/elastic/kibana/pull/203673","mergeCommit":{"message":"[embeddable]
remove reactEmbeddableRegistryHasKey from start API (#203673)\n\nCloses
https://github.com/elastic/kibana/issues/203250\r\n\r\n---------\r\n\r\nCo-authored-by:
Elastic Machine
<[email protected]>\r\nCo-authored-by:
kibanamachine
<[email protected]>","sha":"7b9dd357ef568f25427b7bf70fa00e057f952c05"}},"sourceBranch":"main","suggestedTargetBranches":["8.x"],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","labelRegex":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/203673","number":203673,"mergeCommit":{"message":"[embeddable]
remove reactEmbeddableRegistryHasKey from start API (#203673)\n\nCloses
https://github.com/elastic/kibana/issues/203250\r\n\r\n---------\r\n\r\nCo-authored-by:
Elastic Machine
<[email protected]>\r\nCo-authored-by:
kibanamachine
<[email protected]>","sha":"7b9dd357ef568f25427b7bf70fa00e057f952c05"}},{"branch":"8.x","label":"v8.18.0","labelRegex":"^v8.18.0$","isSourceBranch":false,"state":"NOT_CREATED"}]}]
BACKPORT-->

Co-authored-by: Elastic Machine <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ThomThomson ThomThomson ThomThomson approved these changes

Assignees
No one assigned
Labels
backport:version Backport to applied version labels Feature:Embedding Embedding content via iFrame project:embeddableRebuild release_note:skip Skip the PR/issue when compiling release notes Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas v8.18.0 v9.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[embeddable] remove reactEmbeddableRegistryHasKey from embeddable start API
4 participants
@nreese @elasticmachine @kibanamachine @ThomThomson