-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Security Assistant] Adds audit logging to knowledge base entry changes #203349
Conversation
5e3f46d
to
9590a17
Compare
Pinging @elastic/security-solution (Team: SecuritySolution) |
💚 Build Succeeded
Metrics [docs]Public APIs missing comments
History
|
id: deletedId, | ||
outcome: AUDIT_OUTCOME.SUCCESS, | ||
}) | ||
); | ||
}); | ||
} | ||
if (numFailed > 0) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
do we also want to raport failed actions?
Starting backport for target branches: 8.x |
…es (elastic#203349) (cherry picked from commit 84a2d40)
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
… changes (#203349) (#203886) # Backport This will backport the following commits from `main` to `8.x`: - [[Security Assistant] Adds audit logging to knowledge base entry changes (#203349)](#203349) <!--- Backport version: 9.4.3 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Steph Milovic","email":"[email protected]"},"sourceCommit":{"committedDate":"2024-12-11T18:55:08Z","message":"[Security Assistant] Adds audit logging to knowledge base entry changes (#203349)","sha":"84a2d409537737fb66ddfca63bb3f772deb265e8","branchLabelMapping":{"^v9.0.0$":"main","^v8.18.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:enhancement","v9.0.0","Team: SecuritySolution","backport:prev-minor","Team:Security Generative AI"],"title":"[Security Assistant] Adds audit logging to knowledge base entry changes","number":203349,"url":"https://github.com/elastic/kibana/pull/203349","mergeCommit":{"message":"[Security Assistant] Adds audit logging to knowledge base entry changes (#203349)","sha":"84a2d409537737fb66ddfca63bb3f772deb265e8"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/203349","number":203349,"mergeCommit":{"message":"[Security Assistant] Adds audit logging to knowledge base entry changes (#203349)","sha":"84a2d409537737fb66ddfca63bb3f772deb265e8"}}]}] BACKPORT--> Co-authored-by: Steph Milovic <[email protected]> Co-authored-by: Elastic Machine <[email protected]>
Summary
Resolves https://github.com/elastic/security-team/issues/11367
Adds audit logging events for:
knowledge_base_entry_create
,knowledge_base_entry_update
, andknowledge_base_entry_delete
knowledge_base_entry_create
knowledge_base_entry_update
knowledge_base_entry_delete
To test
xpack.security.audit.enabled: true
-E xpack.security.audit.enabled=true
logs/audit.log
knowledge_base_entry_create
,knowledge_base_entry_update
, andknowledge_base_entry_delete
to ensure audit logs were added for each action you took