Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CI] Fix on-merge pipeline syntax #200129

Merged
merged 1 commit into from
Nov 14, 2024
Merged

[CI] Fix on-merge pipeline syntax #200129

merged 1 commit into from
Nov 14, 2024

Conversation

delanni
Copy link
Contributor

@delanni delanni commented Nov 14, 2024 •
edited by kibanamachine
Loading

Summary

use soft_fail instead of continue_on_failure, as this setting doesn't exist on command steps (https://buildkite.com/docs/pipelines/command-step) - introduced in #197482

@delanni
Copy link
Contributor Author

delanni commented Nov 14, 2024

Tested in: https://buildkite.com/elastic/kibana-migration-pipeline-staging/builds/177 - upload successful. Admin-merging to fast-track this

@delanni delanni added Team:Operations Team label for Operations Team release_note:skip Skip the PR/issue when compiling release notes backport:skip This commit does not require backporting labels Nov 14, 2024
@delanni delanni marked this pull request as ready for review November 14, 2024 09:46
@delanni delanni requested a review from a team as a code owner November 14, 2024 09:46
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-operations (Team:Operations)

@delanni delanni merged commit 68d95e4 into main Nov 14, 2024
15 of 18 checks passed
@delanni delanni deleted the fix-on-merge-syntax branch November 14, 2024 09:46
@delanni delanni removed the backport:skip This commit does not require backporting label Nov 14, 2024
@kibanamachine kibanamachine added the backport:skip This commit does not require backporting label Nov 14, 2024
@delanni delanni added v8.16.0 backport:version Backport to applied version labels v8.17.0 and removed backport:skip This commit does not require backporting labels Nov 14, 2024
@kibanamachine
Copy link
Contributor

Starting backport for target branches: 8.16, 8.x

https://github.com/elastic/kibana/actions/runs/11834688559

@kibanamachine
Copy link
Contributor

Starting backport for target branches: 8.16, 8.x

https://github.com/elastic/kibana/actions/runs/11834688556

@kibanamachine
Copy link
Contributor

💔 All backports failed

Status Branch Result
❌ 8.16 Backport failed because of merge conflicts

You might need to backport the following PRs to 8.16:
- [OAS] Publish OAS bundles to bump.sh (#197482)
❌ 8.x Backport failed because of merge conflicts

You might need to backport the following PRs to 8.x:
- [OAS] Publish OAS bundles to bump.sh (#197482)
- [ci] Remove plugin build (#197125)

Manual backport

To create the backport manually run:

node scripts/backport --pr 200129

Questions ?

Please refer to the Backport tool documentation

1 similar comment
@kibanamachine
Copy link
Contributor

💔 All backports failed

Status Branch Result
❌ 8.16 Backport failed because of merge conflicts

You might need to backport the following PRs to 8.16:
- [OAS] Publish OAS bundles to bump.sh (#197482)
❌ 8.x Backport failed because of merge conflicts

You might need to backport the following PRs to 8.x:
- [OAS] Publish OAS bundles to bump.sh (#197482)
- [ci] Remove plugin build (#197125)

Manual backport

To create the backport manually run:

node scripts/backport --pr 200129

Questions ?

Please refer to the Backport tool documentation

@elasticmachine
Copy link
Contributor

💔 Build Failed

Failed CI Steps

Metrics [docs]

‼️ ERROR: no builds found for mergeBase sha [f4af267]

This was referenced Nov 14, 2024
Merged
Merged
@kibanamachine kibanamachine added the backport missing Added to PRs automatically when the are determined to be missing a backport. label Nov 15, 2024
@kibanamachine
Copy link
Contributor

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create automatically backports add a backport:* label or prevent reminders by adding the backport:skip label.
You can also create backports manually by running node scripts/backport --pr 200129 locally

CAWilson94 pushed a commit to CAWilson94/kibana that referenced this pull request Nov 18, 2024
@delanni @CAWilson94
[CI] Fix on-merge pipeline syntax (elastic#200129)
6524fba 
## Summary

use soft_fail instead of continue_on_failure, as this setting doesn't
exist on command steps
(https://buildkite.com/docs/pipelines/command-step)
@kibanamachine
Copy link
Contributor

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create automatically backports add a backport:* label or prevent reminders by adding the backport:skip label.
You can also create backports manually by running node scripts/backport --pr 200129 locally

CAWilson94 pushed a commit to CAWilson94/kibana that referenced this pull request Nov 18, 2024
@delanni @CAWilson94
[CI] Fix on-merge pipeline syntax (elastic#200129)
a23c8a7 
## Summary

use soft_fail instead of continue_on_failure, as this setting doesn't
exist on command steps
(https://buildkite.com/docs/pipelines/command-step)
@kibanamachine
Copy link
Contributor

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create automatically backports add a backport:* label or prevent reminders by adding the backport:skip label.
You can also create backports manually by running node scripts/backport --pr 200129 locally

4 similar comments
@kibanamachine
Copy link
Contributor

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create automatically backports add a backport:* label or prevent reminders by adding the backport:skip label.
You can also create backports manually by running node scripts/backport --pr 200129 locally

@kibanamachine
Copy link
Contributor

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create automatically backports add a backport:* label or prevent reminders by adding the backport:skip label.
You can also create backports manually by running node scripts/backport --pr 200129 locally

@kibanamachine
Copy link
Contributor

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create automatically backports add a backport:* label or prevent reminders by adding the backport:skip label.
You can also create backports manually by running node scripts/backport --pr 200129 locally

@kibanamachine
Copy link
Contributor

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create automatically backports add a backport:* label or prevent reminders by adding the backport:skip label.
You can also create backports manually by running node scripts/backport --pr 200129 locally

@delanni delanni added backport:skip This commit does not require backporting and removed backport missing Added to PRs automatically when the are determined to be missing a backport. v8.16.0 backport:version Backport to applied version labels v8.17.0 labels Nov 25, 2024
@delanni
Copy link
Contributor Author

delanni commented Nov 25, 2024

This fix is incorporated to the backport of the PR that introduced the issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jloleysens jloleysens jloleysens approved these changes

Assignees
No one assigned
Labels
backport:skip This commit does not require backporting release_note:skip Skip the PR/issue when compiling release notes skip-ci Team:Operations Team label for Operations Team v9.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@delanni @elasticmachine @kibanamachine @jloleysens