-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix deployment agnostic integrations test #199977
Fix deployment agnostic integrations test #199977
Conversation
…ist in order to avoid duplications
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, but my personal nit would be to create a transformation function for the integration.name
plucking.
Smth like:
const name = (integration: Integration) => integration.name
Then use is like:
preExistingIntegrations = (
await callApiAs({
roleScopedSupertestWithCookieCredentials: supertestAdminWithCookieCredentials,
})
).integrations.map(name);
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@elasticmachine merge upstream |
💚 Build Succeeded
Metrics [docs]
History
cc @fake-haris |
Summary
Fixed deployment agnostic integrations test
More details