Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix deployment agnostic integrations test #199977

Merged

Conversation

fake-haris
Copy link
Contributor

Summary

Fixed deployment agnostic integrations test

More details

  • Make API call for fetching integrations before each test.
  • Casted Array to Set in order to avoid duplicated values.

@fake-haris fake-haris requested a review from a team as a code owner November 13, 2024 11:15
@fake-haris fake-haris added backport:skip This commit does not require backporting release_note:skip Skip the PR/issue when compiling release notes test_xpack_functional labels Nov 13, 2024
@fake-haris fake-haris self-assigned this Nov 13, 2024
Copy link
Member

@wayneseymour wayneseymour left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but my personal nit would be to create a transformation function for the integration.name plucking.
Smth like:

const name = (integration: Integration) => integration.name

Then use is like:

        preExistingIntegrations = (
          await callApiAs({
            roleScopedSupertestWithCookieCredentials: supertestAdminWithCookieCredentials,
          })
        ).integrations.map(name);

Copy link
Member

@dmlemeshko dmlemeshko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@pheyos pheyos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@fake-haris
Copy link
Contributor Author

@elasticmachine merge upstream

@elasticmachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

✅ unchanged

History

cc @fake-haris

@fake-haris fake-haris merged commit de2d967 into elastic:main Nov 18, 2024
20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport:skip This commit does not require backporting release_note:skip Skip the PR/issue when compiling release notes test_xpack_functional v9.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants