[ Security Solution ] One discover security context functional tests #199818

logeekal · 2024-11-12T15:55:21Z

Summary

Fixes https://github.com/elastic/security-team/issues/11112

Follow up to

[Security Solution] Add Host/User flyout in One Discover. #199279

Adds functional test for Security Profiles in One Discover.

Checklist

Delete any items that are not applicable to this PR.

Unit or functional tests were updated or added to match the most common scenarios

logeekal · 2024-12-03T13:23:29Z

/ci

logeekal · 2024-12-04T05:59:39Z

/ci

logeekal · 2024-12-04T10:13:50Z

x-pack/test_serverless/functional/test_suites/security/config.example.context_awareness.ts

+
+import { createTestConfig } from '../../config.base';
+
+export default createTestConfig({


@elastic/kibana-data-discovery team, I have created a separate config for example profiles, because if example profiles are activated, they override any solution profile that may be available.

With this approach we are able to keep tests for example profiles and solution profiles separate. Let me know if you think this approach is not optimal.

This approach makes sense to me and is similar to what O11y did. They kept the existing config and just added their tests to their existing O11y config, but IMO Security can structure it however you'd like as long as the example tests still run.

My only minor nit would be I'd personally go with config.examples. instead of config.example. for consistency with other example tests, but just an observation and fine on my end either way.

Done here : 39a02c4

elasticmachine · 2024-12-04T10:14:40Z

Pinging @elastic/security-threat-hunting-investigations (Team:Threat Hunting:Investigations)

wayneseymour

Looks good, just some questions.

x-pack/test_serverless/functional/test_suites/security/config.example.context_awareness.ts

...rverless/functional/test_suites/security/ftr/one_discover/context_awareness/cell_renderer.ts

wayneseymour · 2024-12-04T13:29:23Z

x-pack/test_serverless/functional/test_suites/security/config.context_awareness.ts

@@ -9,19 +9,15 @@ import { createTestConfig } from '../../config.base';

 export default createTestConfig({
  serverlessProject: 'security',
-  testFiles: [require.resolve('../common/discover/context_awareness')],
+  testFiles: [require.resolve('./ftr/one_discover/context_awareness')],


Curious, what's the one_discover convention mean semantically?

Actually, One discover is the name of the project that discover is going through it enables solutions to customize various discover elements.

I am happy to change it to discover if one_discover is confusing and need not be used in code. Will appreciate any comments from you as well @davismcphee

I'd probably recommend going with just discover instead. We're calling the program One Discover currently, but I imagine these tests could outlive that naming.

Makes sense.. done here: 39a02c4

davismcphee

Left a couple minor comments, but it LGTM! Thanks for adding functional tests 👍

davismcphee · 2024-12-05T22:15:22Z

.github/CODEOWNERS

+/x-pack/test_serverless/functional/test_suites/security/config.examples.ts   @elastic/kibana-data-discovery
+/x-pack/test_serverless/functional/test_suites/security/config.example.context_awareness.ts @elastic/kibana-data-discovery
+/x-pack/test_serverless/functional/test_suites/security/config.context_awareness.ts @elastic/security-threat-hunting-investigations @elastic/kibana-data-discovery
+/x-pack/test_serverless/functional/test_suites/security/constants.ts   @elastic/kibana-data-discovery


Suggested change

/x-pack/test_serverless/functional/test_suites/security/constants.ts @elastic/kibana-data-discovery

/x-pack/test_serverless/functional/test_suites/security/constants.ts @elastic/security-threat-hunting-investigations

Should this be assigned to us or Threat Hunting Investigations?

Fixed and changed it to Security Solution here : 618316c

davismcphee · 2024-12-05T22:16:50Z

x-pack/test_serverless/functional/test_suites/security/config.context_awareness.ts

@@ -9,19 +9,15 @@ import { createTestConfig } from '../../config.base';

 export default createTestConfig({
  serverlessProject: 'security',
-  testFiles: [require.resolve('../common/discover/context_awareness')],
+  testFiles: [require.resolve('./ftr/one_discover/context_awareness')],


I'd probably recommend going with just discover instead. We're calling the program One Discover currently, but I imagine these tests could outlive that naming.

davismcphee · 2024-12-05T22:21:11Z

x-pack/test_serverless/functional/test_suites/security/config.example.context_awareness.ts

+
+import { createTestConfig } from '../../config.base';
+
+export default createTestConfig({


This approach makes sense to me and is similar to what O11y did. They kept the existing config and just added their tests to their existing O11y config, but IMO Security can structure it however you'd like as long as the example tests still run.

My only minor nit would be I'd personally go with config.examples. instead of config.example. for consistency with other example tests, but just an observation and fine on my end either way.

elasticmachine · 2024-12-10T09:39:20Z

💚 Build Succeeded

Buildkite Build
Commit: e99ee42

Metrics [docs]

✅ unchanged

History

💚 Build #257758 succeeded 3b5a66b
💔 Build #257744 failed 4d0225e
💚 Build #256848 succeeded 5a5942b
💔 Build #256829 failed 6d81988
💔 Build #256811 failed 5335847
💔 Build #256725 failed 46f3fc0

…lastic#199818) ## Summary Fixes elastic/security-team#11112 Follow up to - elastic#199279 Adds functional test for Security Profiles in One Discover. ### Checklist Delete any items that are not applicable to this PR. - [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios --------- Co-authored-by: kibanamachine <[email protected]>

logeekal added 2 commits December 3, 2024 12:39

security solution profile tests

2f206d5

fix: data format

09d04ec

logeekal force-pushed the one_discover_security_functional_tests branch from b06148d to 09d04ec Compare December 3, 2024 11:40

logeekal added 2 commits December 3, 2024 14:20

add security tests

2c848b0

fix: merge issues

60cb6b4

fix: codeowners + ftr_config

46f3fc0

logeekal added 2 commits December 4, 2024 11:03

fix: config

b6d6f14

fix: config names

5335847

logeekal commented Dec 4, 2024

View reviewed changes

logeekal added release_note:skip Skip the PR/issue when compiling release notes backport:skip This commit does not require backporting Team:Threat Hunting:Investigations Security Solution Investigations Team labels Dec 4, 2024

logeekal marked this pull request as ready for review December 4, 2024 10:14

logeekal requested review from a team as code owners December 4, 2024 10:14

logeekal changed the title ~~One discover security functional tests~~ [Security Solution ] One discover security functional tests Dec 4, 2024

logeekal changed the title ~~[Security Solution ] One discover security functional tests~~ [ Security Solution ] One discover security functional tests Dec 4, 2024

wayneseymour requested changes Dec 4, 2024

View reviewed changes

logeekal added 4 commits December 4, 2024 11:45

fix: add removed file

ad5fc45

fix: PR feedback

6d81988

fix: precise query

f608d0b

fix: codeowners

5a5942b

wayneseymour reviewed Dec 4, 2024

View reviewed changes

wayneseymour approved these changes Dec 4, 2024

View reviewed changes

Ikuni17 approved these changes Dec 4, 2024

View reviewed changes

logeekal changed the title ~~[ Security Solution ] One discover security functional tests~~ [ Security Solution ] One discover security context functional tests Dec 5, 2024

davismcphee approved these changes Dec 5, 2024

View reviewed changes

logeekal and others added 6 commits December 6, 2024 08:22

fix: PR Feeback

39a02c4

[CI] Auto-commit changed files from 'node scripts/generate codeowners'

070fffc

fix: code ownership

618316c

Merge branch 'main' into one_discover_security_functional_tests

4d0225e

Merge branch 'main' into one_discover_security_functional_tests

3b5a66b

Merge branch 'main' into one_discover_security_functional_tests

e99ee42

logeekal enabled auto-merge (squash) December 10, 2024 08:10

logeekal merged commit 9619d61 into elastic:main Dec 10, 2024
8 checks passed

kibanamachine added the v9.0.0 label Dec 10, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[ Security Solution ] One discover security context functional tests #199818

[ Security Solution ] One discover security context functional tests #199818

logeekal commented Nov 12, 2024 •

edited

Loading

logeekal commented Dec 3, 2024

logeekal commented Dec 4, 2024

logeekal Dec 4, 2024

davismcphee Dec 5, 2024

logeekal Dec 6, 2024

elasticmachine commented Dec 4, 2024

wayneseymour left a comment

wayneseymour Dec 4, 2024

logeekal Dec 4, 2024

davismcphee Dec 5, 2024

logeekal Dec 6, 2024

davismcphee left a comment

davismcphee Dec 5, 2024

logeekal Dec 6, 2024

davismcphee Dec 5, 2024

davismcphee Dec 5, 2024

elasticmachine commented Dec 10, 2024


		import { createTestConfig } from '../../config.base';

		export default createTestConfig({

	/x-pack/test_serverless/functional/test_suites/security/constants.ts @elastic/kibana-data-discovery
	/x-pack/test_serverless/functional/test_suites/security/constants.ts @elastic/security-threat-hunting-investigations

[ Security Solution ] One discover security context functional tests #199818

[ Security Solution ] One discover security context functional tests #199818

Conversation

logeekal commented Nov 12, 2024 • edited Loading

Summary

Checklist

logeekal commented Dec 3, 2024

logeekal commented Dec 4, 2024

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

elasticmachine commented Dec 4, 2024

wayneseymour left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

davismcphee left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

elasticmachine commented Dec 10, 2024

💚 Build Succeeded

Metrics [docs]

History

logeekal commented Nov 12, 2024 •

edited

Loading