Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ML] Enabling security for ml_capabilities route #199811

Conversation

jgowdyelastic
Copy link
Member

WIP

@elasticmachine
Copy link
Contributor

🤖 Jobs for this PR can be triggered through checkboxes. 🚧

ℹ️ To trigger the CI, please tick the checkbox below 👇

  • Click to trigger kibana-pull-request for this PR!
  • Click to trigger kibana-deploy-project-from-pr for this PR!

@jgowdyelastic
Copy link
Member Author

Closing this PR.
Adding a security check to this route affects a few other plugins which assume the route will always be available for determining if ML is enabled and accessible for the current user.
The changes in this PR cause unexpected behaviour which would require quite a bit of refactoring to change.

This route is very similar to /api/core/capabilities which itself does not have any security checks.
If this changes we can also change the ML route to use the same tag.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants