Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Discover] Only show logs profiles for O11y solution view #199255
[Discover] Only show logs profiles for O11y solution view #199255
Changes from 11 commits
027b23a
42d9800
1be22ed
fe66899
2362b4a
4a6daf9
ec25ffe
97ea182
726a1f9
25bca72
81c084c
bbe4bd0
5658e92
1a6d95e
a41d43e
28c4f97
6a68792
0b0d350
a9a5e70
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tip
Non-blocking suggestion, as this would work perfectly 👌
This condition should probably reflect how we resolve the O11y root profile, which means this needs to change and be aligned every time we update the logic for the O11y root profile resolution.
I don't expect that to change often, but we might miss some corner cases if we forget to update the logic also here and anywhere else this is implemented in this PR.
Have you considered to use the root profile resolve declaration to keep the resolution logic centralized and inherit it here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As we discussed offline, while we can't re-execute the root profile resolution logic (since it's async while document profile resolution is sync), I've updated the
rootContext
checks to look atprofileId
instead ofsolutionType
, which has the same effect of protecting against future changes: a41d43e.