[Synthetics] migrate first set of tests #198950

dominiqueclarke · 2024-11-05T13:49:47Z

Summary

Relates to #196229

Migrates Synthetics tests to deployment agnostic

dominiqueclarke · 2024-11-08T21:21:17Z

/ci

…ynthetics-deployment-agnostic

dominiqueclarke · 2024-11-14T14:39:50Z

...ck/plugins/observability_solution/synthetics/server/synthetics_service/synthetics_service.ts

    const { apiKey, isValid } = await getAPIKeyForSyntheticsService({ server: this.server });
-    if (!isValid) {
+    // do not check for api key validity if inspecting
+    if (!isValid && !inspect) {


I noticed when I was adjusting the inspect tests, that they would sometime fail on api key not valid. No need to check api key when doing an inspect.

x-pack/test/api_integration/apis/synthetics/add_monitor_private_location.ts

…e_location.ts

dominiqueclarke · 2024-11-14T14:41:29Z

x-pack/test/api_integration/deployment_agnostic/apis/observability/synthetics/create_monitor.ts

+import { getFixtureJson } from './helpers/get_fixture_json';
+import { SyntheticsMonitorTestService } from '../../../services/synthetics_monitor';
+
+// adjust the type of samlAuth


I realized I left this as a comment for myself because samlAuth is set to any here. Didn't get to fixing it.

I like to preface comments like this with TODO to signify that the PR has new tech debt to resolve before merging.

It's a nice reminder to the author themselves and it gives a much stronger indicator to reviewers that something is unfinished.

dominiqueclarke · 2024-11-25T15:43:07Z

/ci

…iniqueclarke/kibana into chore/synthetics-deployment-agnostic

dominiqueclarke · 2024-11-25T20:02:36Z

/ci

dominiqueclarke · 2024-11-25T22:55:15Z

/ci

...st/api_integration/deployment_agnostic/apis/observability/synthetics/create_update_params.ts

…lity/synthetics/create_update_params.ts

dominiqueclarke · 2024-11-26T02:46:57Z

/ci

…-fix'

dominiqueclarke · 2024-11-26T13:08:55Z

/ci

…iniqueclarke/kibana into chore/synthetics-deployment-agnostic

dominiqueclarke · 2024-11-27T15:59:56Z

/ci

shahzad31 · 2024-12-02T15:48:08Z

x-pack/test/api_integration/deployment_agnostic/apis/observability/synthetics/index.ts

+import { DeploymentAgnosticFtrProviderContext } from '../../../ftr_provider_context';
+
+export default function ({ loadTestFile }: DeploymentAgnosticFtrProviderContext) {
+  describe('Synthetics', () => {


Suggested change

describe('Synthetics', () => {

describe('SyntheticsAPITests', () => {

github-actions · 2024-12-02T15:48:24Z

🤖 GitHub comments

Expand to view the GitHub comments

Just comment with:

/oblt-deploy : Deploy a Kibana instance using the Observability test environments.
run docs-build : Re-trigger the docs validation. (use unformatted text in the comment!)

shahzad31

LGTM !!

wayneseymour · 2024-12-02T16:01:40Z

x-pack/test/api_integration/deployment_agnostic/services/synthetics_monitor.ts

+    this.supertest = getService('supertestWithoutAuth');
+    this.samlAuth = getService('samlAuth');
+    this.getService = getService;
+    this.supertestWithoutAuth = getService('supertestWithoutAuth');


First time I've seen supertestWithoutAuth imported twice.
What's the deal?

No deal. It's a mistake. Thanks for the catch!

Looks like it's still imported twice?

It looks like you're on an older commit. Here's the most recent file https://github.com/elastic/kibana/pull/198950/files#diff-f57bbeb09d4030043e0c47cac150f6d4458b2ea7d139bb99784da40b1f7488ecR26

dominiqueclarke · 2024-12-02T16:35:30Z

x-pack/test/api_integration/deployment_agnostic/services/synthetics_monitor.ts

+import { KibanaSupertestProvider } from '@kbn/ftr-common-functional-services';
+import { DeploymentAgnosticFtrProviderContext } from '../ftr_provider_context';
+
+// fix saml auth type


I thought I fixed this. I'll have to adjust.

Do you want this comment here?

This is also outdated. I believe you're looking at an odd commit.

…iniqueclarke/kibana into chore/synthetics-deployment-agnostic

pheyos · 2024-12-04T13:08:48Z

@dominiqueclarke I gave this a run against a real serverless project in MKI and I see many test failures: https://buildkite.com/elastic/appex-qa-serverless-kibana-ftr-tests/builds/3519.
Deployment agnostic tests should also pass when running against MKI projects and ESS deployments.

…iniqueclarke/kibana into chore/synthetics-deployment-agnostic

elasticmachine · 2024-12-11T15:24:14Z

💚 Build Succeeded

Buildkite Build
Commit: 7bce1ca
Kibana Serverless Image: docker.elastic.co/kibana-ci/kibana-serverless:pr-198950-7bce1ca2d862

Metrics [docs]

Unknown metric groups

ESLint disabled line counts

id	before	after	diff
`@kbn/test-suites-xpack`	727	729	+2

Total ESLint disabled count

id	before	after	diff
`@kbn/test-suites-xpack`	752	754	+2

History

💔 Build #258980 failed 7cd6037
💔 Build #258903 failed d79879a
💔 Build #258552 failed 2dc3537
💔 Build #258012 failed 9f8ab54
💚 Build #256425 succeeded 80e24dc

wayneseymour

Left a question.

wayneseymour · 2024-12-11T16:57:50Z

x-pack/test/api_integration/deployment_agnostic/services/synthetics_monitor.ts

+    this.supertest = getService('supertestWithoutAuth');
+    this.samlAuth = getService('samlAuth');
+    this.getService = getService;
+    this.supertestWithoutAuth = getService('supertestWithoutAuth');


Looks like it's still imported twice?

wayneseymour

CR only, LGTM

kibanamachine · 2024-12-12T14:41:23Z

Starting backport for target branches: 8.17, 8.x

https://github.com/elastic/kibana/actions/runs/12298691592

kibanamachine · 2024-12-12T14:51:08Z

💔 All backports failed

Status	Branch	Result
❌	8.17	Backport failed because of merge conflicts You might need to backport the following PRs to 8.17: - [UA] Remove 7->8 multitype check (#203995) - [UA] `kibana-core` ownership (#203410)
❌	8.x	Backport failed because of merge conflicts

Manual backport

To create the backport manually run:

node scripts/backport --pr 198950

Questions ?

Please refer to the Backport tool documentation

dominiqueclarke · 2024-12-12T16:50:41Z

💚 All backports created successfully

Status	Branch	Result
✅	8.x
✅	8.17

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

## Summary Relates to elastic#196229 Migrates Synthetics tests to deployment agnostic --------- Co-authored-by: kibanamachine <[email protected]> Co-authored-by: Shahzad <[email protected]> (cherry picked from commit b74b935) # Conflicts: # .github/CODEOWNERS # x-pack/test/api_integration/deployment_agnostic/default_configs/serverless.config.base.ts

dominiqueclarke added 4 commits November 5, 2024 08:49

migrate first set of tests

ca12729

add additional deployment agnostic tests

5719991

add additional tests

54cfd8b

add additional tests

378e585

dominiqueclarke added 3 commits November 10, 2024 22:05

merge main

5dd98c4

Merge branch 'main' of https://github.com/elastic/kibana into chore/s…

67ad892

…ynthetics-deployment-agnostic

adjust tests

7561381

dominiqueclarke commented Nov 14, 2024

View reviewed changes

x-pack/test/api_integration/apis/synthetics/add_monitor_private_location.ts Outdated Show resolved Hide resolved

dominiqueclarke commented Nov 14, 2024

View reviewed changes

x-pack/test/api_integration/apis/synthetics/add_monitor_private_location.ts Outdated Show resolved Hide resolved

dominiqueclarke added 2 commits November 14, 2024 09:40

Update x-pack/test/api_integration/apis/synthetics/add_monitor_privat…

2753191

…e_location.ts

Update x-pack/test/api_integration/apis/synthetics/add_monitor_privat…

cd199d2

…e_location.ts

dominiqueclarke commented Nov 14, 2024

View reviewed changes

dominiqueclarke added 3 commits November 25, 2024 14:29

adjust types

835999c

Merge branch 'chore/synthetics-deployment-agnostic' of github.com:dom…

9f6932e

…iniqueclarke/kibana into chore/synthetics-deployment-agnostic

merge main

c79ce67

adjust types

54674a8

dominiqueclarke commented Nov 26, 2024

View reviewed changes

...st/api_integration/deployment_agnostic/apis/observability/synthetics/create_update_params.ts Outdated Show resolved Hide resolved

Update x-pack/test/api_integration/deployment_agnostic/apis/observabi…

9a35f07

…lity/synthetics/create_update_params.ts

[CI] Auto-commit changed files from 'node scripts/eslint --no-cache -…

4c4a86c

…-fix'

dominiqueclarke added 2 commits November 27, 2024 10:53

update test

a3f500b

Merge branch 'chore/synthetics-deployment-agnostic' of github.com:dom…

f139c1d

…iniqueclarke/kibana into chore/synthetics-deployment-agnostic

adjust enablement tests

75dfa79

shahzad31 reviewed Dec 2, 2024

View reviewed changes

botelastic bot added the ci:project-deploy-observability Create an Observability project label Dec 2, 2024

shahzad31 added 2 commits December 2, 2024 16:49

Merge branch 'main' into chore/synthetics-deployment-agnostic

aafbab4

update readme

3521fb9

shahzad31 approved these changes Dec 2, 2024

View reviewed changes

wayneseymour requested changes Dec 2, 2024

View reviewed changes

dominiqueclarke commented Dec 2, 2024

View reviewed changes

dominiqueclarke added 4 commits December 2, 2024 11:50

adjust types

1edb90a

Merge branch 'chore/synthetics-deployment-agnostic' of github.com:dom…

3434a89

…iniqueclarke/kibana into chore/synthetics-deployment-agnostic

add codeowners

c8623c4

Merge branch 'main' into chore/synthetics-deployment-agnostic

80e24dc

dominiqueclarke added 6 commits December 6, 2024 22:48

adjust subset of tests to use private locations only

70ad1af

Merge branch 'chore/synthetics-deployment-agnostic' of github.com:dom…

9f8ab54

…iniqueclarke/kibana into chore/synthetics-deployment-agnostic

adjust additional tests

2dc3537

adjust tests for MKI

d79879a

Merge branch 'main' into chore/synthetics-deployment-agnostic

7cd6037

Merge branch 'main' into chore/synthetics-deployment-agnostic

7bce1ca

wayneseymour requested changes Dec 11, 2024

View reviewed changes

wayneseymour approved these changes Dec 12, 2024

View reviewed changes

dominiqueclarke merged commit b74b935 into elastic:main Dec 12, 2024
8 checks passed

dominiqueclarke deleted the chore/synthetics-deployment-agnostic branch December 12, 2024 14:41

This was referenced Dec 12, 2024

[8.x] [Synthetics] migrate first set of tests (#198950) #204083

Open

[8.17] [Synthetics] migrate first set of tests (#198950) #204086

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Synthetics] migrate first set of tests #198950

[Synthetics] migrate first set of tests #198950

dominiqueclarke commented Nov 5, 2024 •

edited by kibanamachine

Loading

dominiqueclarke commented Nov 8, 2024

dominiqueclarke Nov 14, 2024

dominiqueclarke Nov 14, 2024

justinkambic Nov 14, 2024

dominiqueclarke commented Nov 25, 2024

dominiqueclarke commented Nov 25, 2024

dominiqueclarke commented Nov 25, 2024

dominiqueclarke commented Nov 26, 2024

dominiqueclarke commented Nov 26, 2024

dominiqueclarke commented Nov 27, 2024

shahzad31 Dec 2, 2024

github-actions bot commented Dec 2, 2024

shahzad31 left a comment

wayneseymour Dec 2, 2024

dominiqueclarke Dec 2, 2024

wayneseymour Dec 11, 2024

dominiqueclarke Dec 11, 2024

dominiqueclarke Dec 2, 2024

wayneseymour Dec 11, 2024

dominiqueclarke Dec 11, 2024

pheyos commented Dec 4, 2024

elasticmachine commented Dec 11, 2024 •

edited

Loading

ESLint disabled line counts

Total ESLint disabled count

wayneseymour left a comment

wayneseymour Dec 11, 2024

wayneseymour left a comment

kibanamachine commented Dec 12, 2024

kibanamachine commented Dec 12, 2024

dominiqueclarke commented Dec 12, 2024

	describe('Synthetics', () => {
	describe('SyntheticsAPITests', () => {

[Synthetics] migrate first set of tests #198950

[Synthetics] migrate first set of tests #198950

Conversation

dominiqueclarke commented Nov 5, 2024 • edited by kibanamachine Loading

Summary

dominiqueclarke commented Nov 8, 2024

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

dominiqueclarke commented Nov 25, 2024

dominiqueclarke commented Nov 25, 2024

dominiqueclarke commented Nov 25, 2024

dominiqueclarke commented Nov 26, 2024

dominiqueclarke commented Nov 26, 2024

dominiqueclarke commented Nov 27, 2024

Choose a reason for hiding this comment

github-actions bot commented Dec 2, 2024

🤖 GitHub comments

shahzad31 left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

pheyos commented Dec 4, 2024

elasticmachine commented Dec 11, 2024 • edited Loading

💚 Build Succeeded

Metrics [docs]

ESLint disabled line counts

Total ESLint disabled count

History

wayneseymour left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

wayneseymour left a comment

Choose a reason for hiding this comment

kibanamachine commented Dec 12, 2024

kibanamachine commented Dec 12, 2024

💔 All backports failed

Manual backport

Questions ?

dominiqueclarke commented Dec 12, 2024

💚 All backports created successfully

Questions ?

dominiqueclarke commented Nov 5, 2024 •

edited by kibanamachine

Loading

elasticmachine commented Dec 11, 2024 •

edited

Loading