[Connector APIs] Enforce index prefix for managed connectors #117778
+403
−83
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jedrazb
added
>non-issue
:SearchOrg/Extract&Transform
jedrazb
commented
Nov 29, 2024
| ConnectorStatus status = getConnectorStatusFromSearchResult(connector); | ||
|
|
||
| // If connector was connected already, change its status to CONFIGURED as we need to re-connect | ||
| if (status == ConnectorStatus.CONNECTED) { |
There was a problem hiding this comment.
I realised we would always set status CONFIGURED once changing the is_native flag - it's likely wrong, we got here because I copied logic from Kibana initially https://github.com/elastic/kibana/pull/175536/files
jedrazb
commented
Dec 2, 2024
| - match: { results.0.id: "connector-a" } | ||
| - match: { results.0.index_name: "search-1-test" } | ||
| - match: { results.0.language: "pl" } | ||
| - match: { results.0.id: "connector-b" } |
There was a problem hiding this comment.
content- index is first alphabetically so order of list API results changes (we sort by index_name by default)
jedrazb
changed the title
jedrazb
requested review from
seanstory,
artem-shelkovnikov and
navarone-feekery
elasticsearchmachine
added
the
Team:SearchOrg
|
Pinging @elastic/search-eng (Team:SearchOrg) |
|
Pinging @elastic/search-extract-and-transform (Team:Search - Extract & Transform) |
|
Rest compatibility failing because it's not a backward compatible change |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
For
9.x, Connectors will be deployed in an agentless environment. This means the Fleet service account will now be responsible for generating API keys, enabling the connector to read/write from connector state indices and interact with thecontentindex (where data is synced by connector from the 3rd party data source).To maintain granular permissions and avoid granting the Fleet service account access to all indices (e.g.,
*), it has been decided to restrict content index names to those prefixed withcontent-*.This PR introduces restrictions and validations to ensure that Elastic-managed connectors (with
isNative: trueflag) can only attach to indices with thecontent-prefix. We validate index name on:content-then update the connector to native connector)Why this is not a significant breaking change for users:
8.x->9.xmigration, there is a clear migration path for Elastic-managed connectorsAdditionally, the
ConnectorIndexServiceTestshave been unmuted. These tests have been stable for about a year. A few flaky tests had caused them to be muted earlier, but they now run successfully. We need to keep them active.Verification