Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Parse the contents of dynamic objects for [subobjects:false] #117762

Open
wants to merge 7 commits into
base: main
Choose a base branch
from

Conversation

kkrik-es
Copy link
Contributor

@kkrik-es kkrik-es commented Nov 29, 2024

DocumentParser skips parsing dynamic objects when [dynamic:false] is set in a parent object. When [subobjects:false] is also set, dynamic objects should be flattened instead.

Fixes #117544

@kkrik-es kkrik-es added >bug auto-backport Automatically create backport pull requests when merged Team:StorageEngine :StorageEngine/Mapping The storage related side of mappings v8.17.1 v8.18.0 labels Nov 29, 2024
@kkrik-es kkrik-es self-assigned this Nov 29, 2024
@elasticsearchmachine
Copy link
Collaborator

Hi @kkrik-es, I've created a changelog YAML for you.

@kkrik-es kkrik-es marked this pull request as ready for review November 29, 2024 14:28
@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/es-storage-engine (Team:StorageEngine)

Copy link
Member

@martijnvg martijnvg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍 Thanks for fixing this Kostas!

refresh: true
body:
- '{ "index": { } }'
- '{ "my": { "keyword.field": "abc" } }'
Copy link
Contributor

@lkts lkts Dec 2, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we have a test that introducing a dynamic field throws in this case?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
auto-backport Automatically create backport pull requests when merged >bug :StorageEngine/Mapping The storage related side of mappings Team:StorageEngine v8.17.1 v8.18.0 v9.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fields not searchable with subobjects: false and dynamic: false when sent as nested objects
4 participants