-
Notifications
You must be signed in to change notification settings - Fork 24.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Parse the contents of dynamic objects for [subobjects:false] #117762
base: main
Are you sure you want to change the base?
Conversation
Hi @kkrik-es, I've created a changelog YAML for you. |
Pinging @elastic/es-storage-engine (Team:StorageEngine) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍 Thanks for fixing this Kostas!
refresh: true | ||
body: | ||
- '{ "index": { } }' | ||
- '{ "my": { "keyword.field": "abc" } }' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we have a test that introducing a dynamic field throws in this case?
DocumentParser
skips parsing dynamic objects when[dynamic:false]
is set in a parent object. When[subobjects:false]
is also set, dynamic objects should be flattened instead.Fixes #117544