-
Notifications
You must be signed in to change notification settings - Fork 798
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WIP: Elasticsearch 8.7.x #1056
base: main
Are you sure you want to change the base?
WIP: Elasticsearch 8.7.x #1056
Conversation
Hi @woto. Thank you very much for submitting this ❤️ @picandocodigo and I are currently in discussions to try to work out how we might be able to dedicate some time in-house to this project, but your work here will definitely be useful in that effort. We'll try to take a look through your code next week and get back to you as soon as possible. |
Haha, there was a fun moment that I saw only errors from elasticsearch-persistence and elasticsearch-rails gems :) Either way, it looks like it's easy enough to do. If I understand correct. Then all work is that |
@woto Yes it seems like something like this. Also, from other PRs, something change in elasticsearch transport, the class name looks different. See for example: https://github.com/elastic/elasticsearch-rails/pull/1048/files#diff-ee98e028c59b193d58fde56ab4daf54d43c486ae674e63d50ddf300b07943e0fL166 I think quite a lot of people are interested to have this gem compatible with ES 8.X, but I didn't see any feedback from the maintainers since quite some time. I hope this gem is still aimed to be maintained though. |
@technige Hi, I want to inform you that I'm already using this fork in my pet project :) There are still some broken tests in elasticsearch-rails and I hope that you will take them into your own hands ;). It seem I'm not using this functionality. |
Hi @woto, this is great! I'll take a closer look into this Pull Request this week and review it. Initially I'd suggest to remove the |
Hi @picandocodigo, I was wondering if you could provide any updates on the status of this pull request and the progress towards supporting ES 8? |
Hi @dani-sc, I've been working on and off on migrating code and tests to the currently supported versions of Ruby ( Thank you for your patience. |
Hi @picandocodigo , Thank you for your reply. I understand that you're working on this gem on a best-effort basis, but do you have any updates to share about the progress? |
Do you have any estimates for 8.x support? |
There is an 8.X branch in the official repository, but no release yet and the last work was done in September '23. Not sure they'll ever release a v8.X |
😢 🎻 |
Has there been any movement on 8.x support for rails projects? |
Seems like this issue could be closed now 🙌 |
It's draft version of attempt to check what should be done to make elasticsearch-rails work with new elasticsearch-ruby 8.7.x and faraday 2.x. I'm not too deep dived in this gems, but I use it in my pet project. So I decided to try.
This links could help during development:
https://www.elastic.co/blog/moving-from-types-to-typeless-apis-in-elasticsearch-7-0
#1048
#1025
#1049
If you have some thoughts/knowledge how to bring this PR to life faster/better, then let me know.
There don't seem to be many failed tests. https://github.com/woto/elasticsearch-rails/actions/runs/4764875450/jobs/8469977261