Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix error while doing bundle error. Branch name is changed from maste… #1017

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

sonianand11
Copy link

@sonianand11 sonianand11 commented Dec 27, 2021

  • Since the branch name is changed to main from master, bundle install was giving an error in elasticsearch-persistance app which is fixed with specifying branch name
  • Fix the error undefined method each_with_hit for Hash

…r to main. * Fix when run the persistance app.
@cla-checker-service
Copy link

cla-checker-service bot commented Dec 27, 2021

💚 CLA has been signed

@sonianand11
Copy link
Author

@picandocodigo can you please review this PR?

@picandocodigo
Copy link
Member

Hi @sonianand11,
Thanks for submitting this PR. GitHub has some features in place to redirect to main when there's a request to master and it seems to be working as expected with bundler for me. What error were you getting when running bundle install and what versions of Bundler and Ruby were you using?

@sonianand11
Copy link
Author

sonianand11 commented Dec 29, 2021

@picandocodigo Thank you for quick response.
Current ruby version is ruby 2.7.2p137 (2020-10-01 revision 5445e04352) [x86_64-linux]
I am using bundler version 2.1.4 and here is the error

Fetching https://github.com/elastic/elasticsearch-rails.git
fatal: Needed a single revision
Git error: command `git rev-parse --verify master` in directory

I am executing bundle install inside examples directory i.e. elasticsearch-rails/elasticsearch-persistence/examples/notes

If I do git branch in elasticsearch-rails/elasticsearch-persistence/examples/notes it is showing main branch instead of master since we already have changed that.

@deivid-rodriguez
Copy link
Contributor

Hi @sonianand11. If you update Bundler to a version >= 2.2.5, it will just work and there's no need to change the Gemfile.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants