Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[otel] add geoip processor component #6134

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

rogercoll
Copy link
Contributor

What does this PR do?

Adds the GeoIP OpenTelemetry processor into the agent. After adding the import into the internal/pkg/otel/components.go the following commands have been used to follow the project style:

$ go mod tidy; mage fmt; mage update; mage notice;

Why is it important?

It can be used in OpenTelemetry configurations, for example, in a Nginx Ingress controller integration.

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in ./changelog/fragments using the changelog tool
  • I have added an integration test or an E2E test

@rogercoll rogercoll requested a review from a team as a code owner November 25, 2024 10:28
Copy link
Contributor

mergify bot commented Nov 25, 2024

This pull request does not have a backport label. Could you fix it @rogercoll? 🙏
To fixup this pull request, you need to add the backport labels for the needed
branches, such as:

  • backport-./d./d is the label to automatically backport to the 8./d branch. /d is the digit

Copy link
Contributor

mergify bot commented Nov 25, 2024

backport-v8.x has been added to help with the transition to the new branch 8.x.
If you don't need it please use backport-skip label and remove the backport-8.x label.

@mergify mergify bot added the backport-8.x Automated backport to the 8.x branch with mergify label Nov 25, 2024
@pierrehilbert pierrehilbert added the Team:Elastic-Agent-Control-Plane Label for the Agent Control Plane team label Nov 25, 2024
@elasticmachine
Copy link
Contributor

Pinging @elastic/elastic-agent-control-plane (Team:Elastic-Agent-Control-Plane)

@kaanyalti
Copy link
Contributor

@cmacknz Should we skip changelog fragments for this PR?

@cmacknz
Copy link
Member

cmacknz commented Nov 28, 2024

Didn't notice that, this should have a changelog. If EDOT collector has a separate changelog for whatever reason (I'm not aware that it does) it could go there instead, but this is a feature addition to EDOT collector so we should document it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-8.x Automated backport to the 8.x branch with mergify Team:Elastic-Agent-Control-Plane Label for the Agent Control Plane team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants