Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump github.com/elastic/go-sysinfo to v1.15.0 #41750

Merged
merged 1 commit into from
Nov 22, 2024
Merged

Conversation

swiatekm
Copy link
Contributor

@swiatekm swiatekm commented Nov 22, 2024

This update includes a notable performance improvement for determining host ip addresses.

It looks like dependabot is currently blocked by a bunch of large collective updates, so I'm submitting this separately.

Related issues

@swiatekm swiatekm requested a review from a team as a code owner November 22, 2024 16:52
@botelastic botelastic bot added the needs_team Indicates that the issue/PR needs a Team:* label label Nov 22, 2024
@swiatekm swiatekm added Team:Elastic-Agent-Data-Plane Label for the Agent Data Plane team and removed needs_team Indicates that the issue/PR needs a Team:* label labels Nov 22, 2024
@elasticmachine
Copy link
Collaborator

Pinging @elastic/elastic-agent-data-plane (Team:Elastic-Agent-Data-Plane)

Copy link
Contributor

mergify bot commented Nov 22, 2024

This pull request does not have a backport label.
If this is a bug or security fix, could you label this PR @swiatekm? 🙏.
For such, you'll need to label your PR with:

  • The upcoming major version of the Elastic Stack
  • The upcoming minor version of the Elastic Stack (if you're not pushing a breaking change)

To fixup this pull request, you need to add the backport labels for the needed
branches, such as:

  • backport-8./d is the label to automatically backport to the 8./d branch. /d is the digit

Copy link
Contributor

mergify bot commented Nov 22, 2024

backport-8.x has been added to help with the transition to the new branch 8.x.
If you don't need it please use backport-skip label and remove the backport-8.x label.

@mergify mergify bot added the backport-8.x Automated backport to the 8.x branch with mergify label Nov 22, 2024
@andrewkroh
Copy link
Member

You'll need a make notice.

@swiatekm swiatekm added backport-8.16 Automated backport with mergify backport-8.17 Automated backport with mergify labels Nov 22, 2024
This update includes a notable performance improvement for determining
host network interfaces.
Copy link
Member

@andrewkroh andrewkroh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think a changelog entry is warranted that identifies under what scenarios users might see reduced memory usage.

@swiatekm
Copy link
Contributor Author

I think a changelog entry is warranted that identifies under what scenarios users might see reduced memory usage.

I don't really want to quantify the improvement, because it's highly dependent on the environment and configuration. A situation where this comes up in my testing is when beats are monitored over the http /stats endpoint and this calls the function registered here, eventually leading to a sysinfo.Host call. This is a temporary allocation, so whether it makes a difference for a given user is hard to predict.

Honestly, this is mostly for my own peace of mind. I spend a lot of time profiling agent and beats in Kubernetes nowadays, and this distracts me every time it shows up. 😅

@swiatekm swiatekm merged commit 88b0f16 into main Nov 22, 2024
141 checks passed
@swiatekm swiatekm deleted the deps/bump-gosysinfo-1150 branch November 22, 2024 18:50
mergify bot pushed a commit that referenced this pull request Nov 22, 2024
This update includes a notable performance improvement for determining
host network interfaces.

(cherry picked from commit 88b0f16)
mergify bot pushed a commit that referenced this pull request Nov 22, 2024
This update includes a notable performance improvement for determining
host network interfaces.

(cherry picked from commit 88b0f16)
mergify bot pushed a commit that referenced this pull request Nov 22, 2024
This update includes a notable performance improvement for determining
host network interfaces.

(cherry picked from commit 88b0f16)
swiatekm added a commit that referenced this pull request Nov 22, 2024
This update includes a notable performance improvement for determining
host network interfaces.

(cherry picked from commit 88b0f16)

Co-authored-by: Mikołaj Świątek <[email protected]>
swiatekm added a commit that referenced this pull request Nov 22, 2024
This update includes a notable performance improvement for determining
host network interfaces.

(cherry picked from commit 88b0f16)

Co-authored-by: Mikołaj Świątek <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-8.x Automated backport to the 8.x branch with mergify backport-8.16 Automated backport with mergify backport-8.17 Automated backport with mergify dependency Team:Elastic-Agent-Data-Plane Label for the Agent Data Plane team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants