Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WIP: remove functionbeat #41506

Draft
wants to merge 3 commits into
base: main
Choose a base branch
from
Draft

WIP: remove functionbeat #41506

wants to merge 3 commits into from

Conversation

AndersonQ
Copy link
Member

@AndersonQ AndersonQ commented Nov 4, 2024 •
edited
Loading

Proposed commit message

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.

Disruptive User Impact

Author's Checklist

Dependencies:

How to test this PR locally

Related issues

Use cases

Screenshots

Logs

@botelastic botelastic bot added the needs_team Indicates that the issue/PR needs a Team:* label label Nov 4, 2024
@AndersonQ AndersonQ self-assigned this Nov 4, 2024
@AndersonQ AndersonQ added the Team:Elastic-Agent-Data-Plane Label for the Agent Data Plane team label Nov 4, 2024
@botelastic botelastic bot removed the needs_team Indicates that the issue/PR needs a Team:* label label Nov 4, 2024
@mergify Mergify
Copy link
Contributor

mergify bot commented Nov 4, 2024

This pull request does not have a backport label.
If this is a bug or security fix, could you label this PR @AndersonQ? 🙏.
For such, you'll need to label your PR with:

  • The upcoming major version of the Elastic Stack
  • The upcoming minor version of the Elastic Stack (if you're not pushing a breaking change)

To fixup this pull request, you need to add the backport labels for the needed
branches, such as:

  • backport-8./d is the label to automatically backport to the 8./d branch. /d is the digit

@mergify Mergify
Copy link
Contributor

mergify bot commented Nov 4, 2024

backport-8.x has been added to help with the transition to the new branch 8.x.
If you don't need it please use backport-skip label and remove the backport-8.x label.

@mergify mergify bot added the backport-8.x Automated backport to the 8.x branch with mergify label Nov 4, 2024
@AndersonQ AndersonQ added backport-skip Skip notification from the automated backport with mergify and removed backport-8.x Automated backport to the 8.x branch with mergify labels Nov 4, 2024
AndersonQ
AndersonQ commented Nov 7, 2024
View reviewed changes
dev-tools/cmd/update_go/update_go_version.go
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The lint issues aren't related to this PR, thus I'm not planning to fix them.

@AndersonQ AndersonQ requested a review from pazone November 7, 2024 13:29
@mergify Mergify
Copy link
Contributor

mergify bot commented Nov 12, 2024

This pull request is now in conflicts. Could you fix it? 🙏
To fixup this pull request, you can check out it locally. See documentation: https://help.github.com/articles/checking-out-pull-requests-locally/

git fetch upstream
git checkout -b 40745-remove-functionbeat upstream/40745-remove-functionbeat
git merge upstream/main
git push upstream 40745-remove-functionbeat

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pazone pazone Awaiting requested review from pazone

At least 1 approving review is required to merge this pull request.

Assignees

@AndersonQ AndersonQ

Labels
backport-skip Skip notification from the automated backport with mergify Team:Elastic-Agent-Data-Plane Label for the Agent Data Plane team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Remove functionbeat binaries
1 participant
@AndersonQ