-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
renaming "elastic" user to "username" in cloud setup docs #40720
base: main
Are you sure you want to change the base?
Conversation
This pull request does not have a backport label.
To fixup this pull request, you need to add the backport labels for the needed
NOTE: |
59e242b
to
0d423fe
Compare
Hi @rehanpfmr, I'm trying to understand the motivation for this change, "elastic" is the default username we use in our documentation, it is also the default username used by Elasticsearch, many of our testing/automation tools as well as the username used when deploying on Elastic Cloud and using the cloud ID. I fail to see the benefit of this change. |
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Another thing I didn't understand is why you removed auditbeat/module/file_integrity/testdata/garble_macho_executable.
#username: "elastic" | ||
#username: "username" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Our documentation files are auto-generated based on templates, I don't see the templates modified on this PR, there are two of them:
- libbeat/_meta/config/output-elasticsearch.yml.tmpl
- libbeat/_meta/config/output-elasticsearch.reference.yml.tmpl
After editing them, you can generate all files by running make update
from the root of the repo.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@belimawr , that helps. i will work on the above recommendation's and update PR accoringly
Pinging @elastic/elastic-agent-data-plane (Team:Elastic-Agent-Data-Plane) |
modified: libbeat/docs/monitoring/monitoring-internal-collection.asciidoc modified: libbeat/docs/output-cloud.asciidoc modified: x-pack/functionbeat/docs/config-options-aws.asciidoc
…onfiguration files
Co-authored-by: Tiago Queiroz <[email protected]>
Co-authored-by: Tiago Queiroz <[email protected]>
8700c58
to
d83dcd8
Compare
This pull request primarily involves changes to the authentication credentials in various configuration files and documentation. The key change is the replacement of the default username "elastic" with "username". This is reflected in the CHANGELOG-developer.asciidoc and CHANGELOG-developer.next.asciidoc files, which list this as a breaking change.
Authentication Credentials Update:
auditbeat/auditbeat.reference.yml, auditbeat/auditbeat.yml, deploy/cloudfoundry/filebeat/filebeat.yml, deploy/cloudfoundry/metricbeat/metricbeat.yml, dev-tools/packaging/files/ironbank/auditbeat/config/auditbeat.yml, filebeat/filebeat.reference.yml, filebeat/filebeat.yml: Updated the commented-out default username from "elastic" to "username" in the authentication credentials section. [1] [2] [3] [4] [5] [6] [7] [8] [9]
Documentation Update:
CHANGELOG-developer.asciidoc, CHANGELOG-developer.next.asciidoc: Documented the change in default username as a breaking change. [1] [2]
libbeat/docs/monitoring/monitoring-internal-collection.asciidoc, libbeat/docs/output-cloud.asciidoc, x-pack/functionbeat/docs/config-options-aws.asciidoc: Updated the example configuration to reflect the new default username. [1] [2] [3]