Fix datetime for datasets files generated. #42
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
agalbachicar
approved these changes
Sep 19, 2024
There was a problem hiding this comment.
LGTM
I noticed this the other day and changed the behavior in a local branch to append the stamp_str rather than doing the replacement.
This works as well. Before going in, please sync with @ndelima-ekumen regarding pre-commit
Fix pre-commit issues.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The WRITER_CONFIG: output_dir wasn't creating properly the dataset path with the timestamp. The bug was fixed adding it as a Placeholder in the config.yml file and this placeholder is replaced with the current timestamp when the configuration is loaded.