Skip to content
This repository has been archived by the owner on Oct 26, 2023. It is now read-only.

Added a feature that highlights posts with red border that contains words/phrases from a list #38

Open
wants to merge 8 commits into
base: master
Choose a base branch
from

Conversation

kevinjpluck
Copy link

Hi Eric,

We found that our campfire room got quite noisy with hubot etal posting errors and warnings so a lot of critical messages got lost. So instead of retuning hubot (which is probably the sensible approach) I added this feature to kindling.

I hope you like it :-)

@ejensen
Copy link
Owner

ejensen commented Aug 11, 2013

Thank you for the pull request, Kevin.

I've encountered a few issues with the new feature.

  1. When the wordlist is empty, the highlighter throwsTypeError: Cannot call method 'split' of undefined
  2. The wordlist doesn't seem to save unless another element in the menu is clicked.
  3. The wordlist highlighting is case-sensitive (is this intentional?).

In commit ce1c3d9, I added the ability to highlight occurrences of words from a list. You may want to build upon that related feature. Maybe build a sub-option that highlights the entire message (if that's your desired effect), in addition to highlighting the keyword.

Hope that helps, and thanks again!

@kevinjpluck
Copy link
Author

Thanks Eric, I'll have a look at your issues, correct them and get back to you.

I'm a tad new to js and chrome extensions so any criticism is appreciated!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants