use absolute path when environment variable; RUBOCOP_CHECKSTYLE_FORMA…

…TTER_ABSOLUTE_PATH is defined
eitoball · Apr 23, 2017 · 338ce2d · 338ce2d
1 parent 5cd4e38
commit 338ce2d
Show file tree

Hide file tree

Showing 2 changed files with 20 additions and 3 deletions.
diff --git a/lib/rubocop/formatter/checkstyle_formatter.rb b/lib/rubocop/formatter/checkstyle_formatter.rb
@@ -20,10 +20,8 @@ def started(_target_file)
       def file_finished(file, offences)
         REXML::Element.new('file', @checkstyle).tap do |f|
           path_name = file
-          path_name = relative_path(file) if defined?(relative_path)
+          path_name = relative_path(path_name) if !ENV.has_key?('RUBOCOP_CHECKSTYLE_FORMATTER_ABSOLUTE_PATH') && defined?(relative_path)
           f.attributes['name'] = path_name
-          # f.attributes['name'] =
-            # defined?(PathUtil) ? PathUtil.relative_path(file) : file
           add_offences(f, offences)
         end
       end

diff --git a/spec/rubocop/formatter/checkstyle_formatter_spec.rb b/spec/rubocop/formatter/checkstyle_formatter_spec.rb
@@ -51,6 +51,25 @@ module Formatter
           end
         end
       end
+
+      context 'RUBOCOP_CHECKSTYLE_FORMATTER_ABSOLUTE_PATH is defined' do
+        around do |example|
+          ENV['RUBOCOP_CHECKSTYLE_FORMATTER_ABSOLUTE_PATH'] = 'true'
+          example.run
+          ENV.delete('RUBOCOP_CHECKSTYLE_FORMATTER_ABSOLUTE_PATH')
+        end
+
+        it 'should use absolute path in name attribute of file tag' do
+          output = StringIO.new
+          formatter = described_class.new(output)
+          formatter.started(file)
+          formatter.file_finished(file, cop.respond_to?(:offenses) ? cop.offenses : cop.offences)
+          formatter.finished([file])
+          doc = REXML::Document.new(output.string)
+          file = REXML::XPath.first(doc, '/checkstyle/file')
+          expect(Pathname.new(file['name'])).to be_absolute
+        end
+      end
     end
   end
 end