Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add socketcan option to receive error frames #161

Merged
merged 2 commits into from
Sep 22, 2023
Merged

feat: add socketcan option to receive error frames #161

merged 2 commits into from
Sep 22, 2023

Conversation

anajavi
Copy link
Contributor

@anajavi anajavi commented May 28, 2023 •
edited
Loading

This adds socketcan dialoptions that can be used to enable can error frame receiving.

	conn, err := socketcan.DialContext(ctx, "can","can0", socketcan.WithReceiveErrorFrames())

edit: added test for the dialoption

@anajavi anajavi requested a review from a team as a code owner May 28, 2023 20:29
Edholm
Edholm approved these changes Aug 25, 2023
View reviewed changes
Copy link
Member

@Edholm Edholm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution and sorry for the long delay :)

@anajavi
Copy link
Contributor Author

anajavi commented Sep 19, 2023

Thanks, can this be merged and released?

@Edholm
Copy link
Member

Edholm commented Sep 19, 2023

Yes, rebase on master and we should be good to go

@anajavi
Copy link
Contributor Author

anajavi commented Sep 21, 2023

Yes, rebase on master and we should be good to go

This is now rebased

@Edholm
Copy link
Member

Edholm commented Sep 21, 2023

Are you able to merge? Otherwise I'll do it

@anajavi
Copy link
Contributor Author

anajavi commented Sep 21, 2023

Are you able to merge? Otherwise I'll do it

I don't see merge button, so go ahead. Thank you!

@Edholm Edholm merged commit 38b311b into einride:master Sep 22, 2023
1 check passed
@anajavi anajavi deleted the canerrframe branch September 26, 2023 09:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Edholm Edholm Edholm approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@anajavi @Edholm