Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(node)!: Implement NodeBuilder and remove NodeConfig #472

Merged
merged 23 commits into from
Dec 11, 2024
Merged

feat(node)!: Implement NodeBuilder and remove NodeConfig #472

merged 23 commits into from
Dec 11, 2024

Conversation

oblique
Copy link
Member

@oblique oblique commented Dec 4, 2024

No description provided.

@oblique oblique marked this pull request as draft December 4, 2024 17:15
@oblique oblique mentioned this pull request Dec 4, 2024
Closed
@oblique oblique changed the title feat(node)!: Implement NodeBuilder feat(node)!: Implement NodeBuilder and remove NodeConfig Dec 5, 2024
oblique
oblique commented Dec 5, 2024
View reviewed changes
node/src/network.rs Outdated Show resolved Hide resolved
oblique
oblique commented Dec 5, 2024
View reviewed changes
node/src/node/builder.rs Outdated Show resolved Hide resolved
@oblique oblique marked this pull request as ready for review December 5, 2024 17:11
@oblique oblique requested review from zvolin and fl0rek December 5, 2024 17:12
@Wondertan
Copy link

OOC, whats the motivation behind this change?

@zvolin
Copy link
Member

zvolin commented Dec 6, 2024

@Wondertan builder allows for changing the way you configure node without api breaks.
Adding a public field to config struct is always breaking as anyone who creates it by hand will need to fill it

zvolin
zvolin reviewed Dec 6, 2024
View reviewed changes
node/src/node/builder.rs Outdated Show resolved Hide resolved
zvolin
zvolin reviewed Dec 6, 2024
View reviewed changes
node/src/node/builder.rs Outdated Show resolved Hide resolved
zvolin
zvolin reviewed Dec 10, 2024
View reviewed changes
node/src/node/builder.rs Outdated Show resolved Hide resolved
zvolin
zvolin approved these changes Dec 10, 2024
View reviewed changes
Copy link
Member

@zvolin zvolin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good

@oblique oblique requested a review from zvolin December 10, 2024 15:41
fl0rek
fl0rek approved these changes Dec 11, 2024
View reviewed changes
Copy link
Member

@fl0rek fl0rek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Few suggestions wrt comments, otherwise looking good!

node/src/node/builder.rs Outdated Show resolved Hide resolved
node/src/node/builder.rs Outdated Show resolved Hide resolved
node/src/node/builder.rs Outdated Show resolved Hide resolved
node/src/node/builder.rs Outdated Show resolved Hide resolved
node/src/node/builder.rs Outdated Show resolved Hide resolved
oblique and others added 5 commits December 11, 2024 14:59
@oblique @fl0rek
Update node/src/node/builder.rs
3758c78 
Co-authored-by: Mikołaj Florkiewicz <[email protected]>
Signed-off-by: Yiannis Marangos <[email protected]>
@oblique @fl0rek
Update node/src/node/builder.rs
36c03ca 
Co-authored-by: Mikołaj Florkiewicz <[email protected]>
Signed-off-by: Yiannis Marangos <[email protected]>
@oblique @fl0rek
Update node/src/node/builder.rs
6ea852b 
Co-authored-by: Mikołaj Florkiewicz <[email protected]>
Signed-off-by: Yiannis Marangos <[email protected]>
@oblique @fl0rek
Update node/src/node/builder.rs
20def8d 
Co-authored-by: Mikołaj Florkiewicz <[email protected]>
Signed-off-by: Yiannis Marangos <[email protected]>
@oblique @fl0rek
Update node/src/node/builder.rs
f00f238 
Co-authored-by: Mikołaj Florkiewicz <[email protected]>
Signed-off-by: Yiannis Marangos <[email protected]>
@oblique oblique requested a review from fl0rek December 11, 2024 13:02
fl0rek
fl0rek approved these changes Dec 11, 2024
View reviewed changes
Copy link
Member

@fl0rek fl0rek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@fl0rek fl0rek merged commit 7705ece into eigerco:main Dec 11, 2024
6 checks passed
@zvolin zvolin mentioned this pull request Dec 11, 2024
Closed
@oblique oblique deleted the feat/node-builder branch December 11, 2024 16:14
This was referenced Dec 13, 2024
Closed
Closed
Closed
Closed
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zvolin zvolin zvolin approved these changes

@fl0rek fl0rek fl0rek approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@oblique @Wondertan @zvolin @fl0rek