feat(node-wasm, types)!: Add method to get blobs for wasm #468
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zvolin
reviewed
Nov 28, 2024
fl0rek
force-pushed
the
feat/blob_service
branch
from
a09db41 to
121e02d
Compare
fl0rek
force-pushed
the
feat/blob_service
branch
from
121e02d to
a8a1b20
Compare
fl0rek
changed the title
fl0rek
force-pushed
the
feat/blob_service
branch
from
aae8355 to
795e6ac
Compare
fl0rek
force-pushed
the
feat/blob_service
branch
2 times, most recently
from
f3e5b98 to
93514f2
Compare
fl0rek
force-pushed
the
feat/blob_service
branch
from
93514f2 to
bcfefca
Compare
oblique
reviewed
Dec 11, 2024
fl0rek
force-pushed
the
feat/blob_service
branch
from
bb88d09 to
20c2276
Compare
fl0rek
force-pushed
the
feat/blob_service
branch
from
20c2276 to
6a7b71c
Compare
Closed
zvolin
reviewed
Dec 13, 2024
grpc/tests/tonic.rs
Outdated
There was a problem hiding this comment.
I think we can revert changes there and in utils.rs. We've already resolved ci failures about missing docs and stuff at another level
zvolin
reviewed
Dec 13, 2024
| @@ -91,6 +93,7 @@ pub type Proof = nmt_rs::simple_merkle::proof::Proof<NamespacedSha2Hasher>; | |||
| /// - secondary reserved namespaces - those use version `0xff` so they are always placed after | |||
| /// user-submitted data. | |||
| #[derive(Copy, Clone, Debug, PartialEq, Eq, Ord, PartialOrd, Hash)] | |||
| #[cfg_attr(all(feature = "wasm-bindgen", target_arch = "wasm32"), wasm_bindgen)] | |||
There was a problem hiding this comment.
I'm wondering how usage of namespace works in js, as we don't expose any methods iiuc
There was a problem hiding this comment.
good point, added getters for id and version as well as to_byte equivalent.
oblique
approved these changes
Dec 13, 2024
fl0rek
force-pushed
the
feat/blob_service
branch
from
64f548e to
8708c04
Compare
fl0rek
force-pushed
the
feat/blob_service
branch
from
05de0a8 to
ab3cff9
Compare
fl0rek
force-pushed
the
feat/blob_service
branch
from
b70978a to
5ec36f8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.