-
Notifications
You must be signed in to change notification settings - Fork 38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(wasm): Run Lumina in a Shared Worker #265
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fl0rek
force-pushed
the
feat/wasm-node-in-worker
branch
from
April 11, 2024 08:10
ddb3ea8
to
ac8c77e
Compare
oblique
reviewed
Apr 26, 2024
zvolin
reviewed
May 7, 2024
zvolin
reviewed
May 7, 2024
zvolin
reviewed
May 7, 2024
zvolin
reviewed
May 7, 2024
zvolin
reviewed
May 7, 2024
zvolin
reviewed
May 7, 2024
zvolin
force-pushed
the
feat/wasm-node-in-worker
branch
from
May 10, 2024 13:38
d9b19f6
to
0495d05
Compare
zvolin
reviewed
May 10, 2024
oblique
reviewed
May 13, 2024
fl0rek
force-pushed
the
feat/wasm-node-in-worker
branch
from
May 16, 2024 11:54
7bf8ae9
to
7fe0397
Compare
fl0rek
force-pushed
the
feat/wasm-node-in-worker
branch
from
May 16, 2024 11:56
7fe0397
to
d3a2c92
Compare
zvolin
reviewed
May 16, 2024
Co-authored-by: Maciej Zwoliński <[email protected]> Signed-off-by: Mikołaj Florkiewicz <[email protected]>
oblique
reviewed
Jun 21, 2024
Co-authored-by: Yiannis Marangos <[email protected]> Signed-off-by: Mikołaj Florkiewicz <[email protected]>
oblique
reviewed
Jun 23, 2024
fl0rek
force-pushed
the
feat/wasm-node-in-worker
branch
from
June 24, 2024 06:40
2a09295
to
d93a126
Compare
oblique
approved these changes
Jun 25, 2024
zvolin
approved these changes
Jun 25, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚀
Closed
Closed
Closed
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces several features:
NodeDriver
replaces WasmNode and is responsible for steering actual lumina node running inside a Worker. Multiple tabs from the same context can access the same lumina instance. After spawning the shared worker, NodeDriver establishes a request-response communication channel over JS primitives.onconnect
event means that a new connection happened and we're supposed to useevent.port[0]
to communicate with a newly connectedNodeDriver
by responding with results of the command we're sent.