Fixing url to png or jpg conversion bugs #19
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Nice tool but when comparing to the game and TTS Mod Backup on Nexus, it doesn't always figure out correctly if a URL is a PNG or JPG.
This PR fixes the issues I found by using the content type header to figure out which type it is.
and then looks for both files in order to backup.
I tested with:
https://steamcommunity.com/sharedfiles/filedetails/?id=1686824824
which has a set of jpgs and pngs images.
For example,
http://cloud-3.steamusercontent.com/ugc/1000268739968105278/2E183FDC5E647428A96F0F739406794A7CAA4F33/
and
http://i.imgur.com/g1M6tbY.jpg
are both jpg files which prior, it incorrectly thinks they are png files.