Allow environment provider jobs not bound to cluster

[andmat900]

Applicable Issues

• Remove assumption that an environment request has the cluster label #265

Description of the Change

This change adds handling of environment requests that do not have cluster-label set.

Alternate Designs

Possible Drawbacks

Sign-off

Developer's Certificate of Origin 1.1

By making a contribution to this project, I certify that:

(a) The contribution was created in whole or in part by me and I
have the right to submit it under the open source license
indicated in the file; or

(b) The contribution is based upon previous work that, to the best
of my knowledge, is covered under an appropriate open source
license and I have the right under that license to submit that
work with modifications, whether created in whole or in part
by me, under the same open source license (unless I am
permitted to submit under a different license), as indicated
in the file; or

(c) The contribution was provided directly to me by some other
person who certified (a), (b) or (c) and I have not modified
it.

(d) I understand and agree that this project and the contribution
are public and that a record of the contribution (including all
personal information I submit with it, including my sign-off) is
maintained indefinitely and may be redistributed consistent with
this project or the open source license(s) involved.

Signed-off-by: [email protected]

[t-persson]

How much of this config is actually required by the EnvironmentRequest?

[andmat900]

I am adding only ServiceAccountName and SecretRefName as optional.

Can't say about the rest. Any changes there should be done separately.

[t-persson]

this config in this case is the SecretRefName. If we are to remove the dependency to cluster then we should identify if that configuration is actually necessary and which parts of it that are and if we can fix it so that they are optional.

[andmat900]

This change only allows starting environment provider jobs without a cluster.
They will be started by the default SA, but won't succeed due to permissions.
To make them succeed will require service accounts not bound to cluster (like global-provider instead of <cluster_name>-provider).

[andmat900]

In update 862f006 SecretRefName is replaced with JobConfig. The idea is to provide only the required variables.

[andmat900]

Commit dc58833 works with 'etosctl testrun start'.

[andmat900]

When a environment request object is created via kubectl create, the environment provider job is currently failing due to AssertionError: ActivityTriggered must exist for the environment provider.

[andmat900]

Environment requests can be now created without cluster. Verified with registry.nordix.org/eiffel/etos-environment-provider:d5e65c2f.

$ kubectl create -n etos-ns -f env_request.yaml
...
$ kubectl get environmentrequests -n etos-ns
NAME                    READY   REASON   MESSAGE
quicktest-qhb2m-hkt0b   True    Done     Successfully provisioned an environment