Get environments from Kubernetes #79
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
t-persson
requested review from
fredjn and
andmat900
and removed request for
a team
t-persson
force-pushed
the
get-sub-suites-from-k8s
branch
from
db08af6 to
c5a2bf3
Compare
andmat900
reviewed
Dec 12, 2024
| "Start collecting sub suite definitions (timeout=%ds).", | ||
| self.etos.config.get("WAIT_FOR_ENVIRONMENT_TIMEOUT"), | ||
| ) | ||
| if os.getenv("IDENTIFIER") is not None: |
There was a problem hiding this comment.
IDENTIFIER is set in v1+? If so, please add a comment.
There was a problem hiding this comment.
Moved to esr_parameters.
t-persson
commented
Dec 13, 2024
projects/etos_suite_runner/src/etos_suite_runner/lib/esr_parameters.py
Outdated
Show resolved
Hide resolved
andmat900
approved these changes
Dec 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Applicable Issues
Preparatory change for: eiffel-community/etos#306
Description of the Change
Update so that the ESR will get the sub suite definition from Kubernetes instead of Eiffel when running using the ETOS controller.
Alternate Designs
I would want the ETOS controller to pass in an environment to the ESR when it has been created, thus creating one ESR for each environment just to manage and keep track of the ETR execution. This would, however, be a bigger change and I want to fix the problems we are seeing where the environment provider complains about a missing activity triggered (which this change can enable a fix for) first.
Possible Drawbacks
Another branch in the code, making the ESR a bit more complex.
Sign-off
Developer's Certificate of Origin 1.1
By making a contribution to this project, I certify that:
(a) The contribution was created in whole or in part by me and I
have the right to submit it under the open source license
indicated in the file; or
(b) The contribution is based upon previous work that, to the best
of my knowledge, is covered under an appropriate open source
license and I have the right under that license to submit that
work with modifications, whether created in whole or in part
by me, under the same open source license (unless I am
permitted to submit under a different license), as indicated
in the file; or
(c) The contribution was provided directly to me by some other
person who certified (a), (b) or (c) and I have not modified
it.
(d) I understand and agree that this project and the contribution
are public and that a record of the contribution (including all
personal information I submit with it, including my sign-off) is
maintained indefinitely and may be redistributed consistent with
this project or the open source license(s) involved.
Signed-off-by: Tobias Persson [email protected]