Remove MCParticlesHeadOnFrameNoBeamFX from default output collections list #1681
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Why would we want to remove this?
…On Wed, Nov 27, 2024, 8:05 PM Sakib Rahman ***@***.***> wrote:
@rahmans1 <https://github.com/rahmans1> requested your review on: #1681
<#1681> Remove
MCParticlesHeadOnFrameNoBeamFX from default output collections list.
—
Reply to this email directly, view it on GitHub
<#1681 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/ADABSFZBB65F5CIG7F4TP232CZT45AVCNFSM6AAAAABSUADPA6VHI2DSMVQWIX3LMV45UABCJFZXG5LFIV3GK3TUJZXXI2LGNFRWC5DJN5XDWMJVGQ2TSMBQHAZTSNA>
.
You are receiving this because your review was requested.Message ID:
***@***.***>
|
rahmans1
temporarily deployed
to
github-pages
GitHub Actions
Inactive
Capybara summary for PR 1681
|
Because it is causing a 20x increase in output size for reasons not understood. It's either removing this and running for the collaboration with the rest, or running a November production with only 4% of the statistics. Once the problem is understood and fixed (which could be tonight or tomorrow), we can enable it again. This is the plan B branch. |
|
That's strange, it should only be saving status == 1 particles and
shouldn't be able to exceed the size of MCparticles. Okay, cool.
…On Wed, Nov 27, 2024, 8:51 PM Wouter Deconinck ***@***.***> wrote:
Why would we want to remove this?
Because it is causing a 20x increase in output size for reasons not
understood. It's either removing this and running for the collaboration
with the rest, or running a November production woth only 4% of the
statistics.
Once the problem is understood and fixed (which could be tonight or
tomorrow), we can enable it again.
—
Reply to this email directly, view it on GitHub
<#1681 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/ADABSFYJXKUG7BVXK6Q5BH32CZZKLAVCNFSM6AAAAABSUADPA6VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDKMBVGEYTANJUHA>
.
You are receiving this because your review was requested.Message ID:
***@***.***>
|
ajentsch
approved these changes
Nov 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Briefly, what does this PR introduce?
Remove MCParticlesHeadOnFrameNoBeamFX from default output collections list to prevent file size explosion. See issue#812 on epic.
What kind of change does this PR introduce?
Please check if this PR fulfills the following:
Does this PR introduce breaking changes? What changes might users need to make to their code?
Does this PR change default behavior?