Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(ci): store prmon summary as artifact #1603

Merged
merged 1 commit into from
Aug 26, 2024
Merged

Conversation

wdconinc
Copy link
Contributor

Briefly, what does this PR introduce?

This PR adds prmon monitoring of the reconstruction jobs eicrecon-gun and eicrecon-dis, and uploads the summary as an artifact. This can be used later as a way to fail when execution time or memory usage is significantly changed by a PR. We first need to get a sense of how much variability there is due to the GitHub backend nodes.

What kind of change does this PR introduce?

  • Bug fix (issue #__)
  • New feature (issue: catch large slowdowns in performance sooner)
  • Documentation update
  • Other: __

Please check if this PR fulfills the following:

  • Tests for the changes have been added
  • Documentation has been added / updated
  • Changes have been communicated to collaborators

Does this PR introduce breaking changes? What changes might users need to make to their code?

No.

Does this PR change default behavior?

No.

@wdconinc wdconinc requested review from a team and ruse-traveler and removed request for a team August 25, 2024 17:37
Copy link

Copy link
Contributor

@ruse-traveler ruse-traveler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@ruse-traveler ruse-traveler added this pull request to the merge queue Aug 26, 2024
Merged via the queue into main with commit ea4b742 Aug 26, 2024
85 of 87 checks passed
@ruse-traveler ruse-traveler deleted the prmon-summary branch August 26, 2024 20:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants