Skip to content

Commit

Permalink
fix: write local position in mm in CalorimeterHitsMerger (#1598)
Browse files Browse the repository at this point in the history
### Briefly, what does this PR introduce?
This PR fixes an issue where the `local` position of merged hits is
written in DD4hep units instead of EDM4eic units. The subsequent
clustering expects the `local` position to be in EDM4eic units of
course.

### What kind of change does this PR introduce?
- [x] Bug fix (issue: no clustering in backward HCal,
https://chat.epic-eic.org/main/pl/pg6fwpimetgf8esmz4zfotwc3c)
- [ ] New feature (issue #__)
- [ ] Documentation update
- [ ] Other: __

### Please check if this PR fulfills the following:
- [ ] Tests for the changes have been added
- [ ] Documentation has been added / updated
- [x] Changes have been communicated to collaborators @lkosarz 

### Does this PR introduce breaking changes? What changes might users
need to make to their code?
No.

### Does this PR change default behavior?
Fixes backward HCal clusters (should have changing number of clusters,
distributed over 10x larger area).
  • Loading branch information
wdconinc authored Aug 26, 2024
1 parent d1798b7 commit 627c9d1
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion src/algorithms/calorimetry/CalorimeterHitsMerger.cc
Original file line number Diff line number Diff line change
Expand Up @@ -121,7 +121,7 @@ void CalorimeterHitsMerger::process(
gpos.x() / dd4hep::mm, gpos.y() / dd4hep::mm, gpos.z() / dd4hep::mm
);
const decltype(edm4eic::CalorimeterHitData::local) local(
pos.x(), pos.y(), pos.z()
pos.x() / dd4hep::mm, pos.y() / dd4hep::mm, pos.z() / dd4hep::mm
);

out_hits->create(
Expand Down

0 comments on commit 627c9d1

Please sign in to comment.