Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update ElasticSearchDaoImpl.java #7

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Update ElasticSearchDaoImpl.java #7

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions ...ashboard-analytics/src/main/java/com/tarento/analytics/dao/impl/ElasticSearchDaoImpl.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -165,6 +165,7 @@ public Map<String, Object> searchData(String index, String type, Map<String, Obj

long startTime = System.currentTimeMillis();
logger.info("ElasticSearchUtil searchData method started at ==" + startTime + " for Type " + type);
System.out.println("index name"+index);
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Replace System.out.println with logger.debug for consistency and better control over logging levels.

- System.out.println("index name"+index);
+ logger.debug("index name: {}", index);
Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation.

Suggested change
System.out.println("index name"+index);
logger.debug("index name: {}", index);

SearchSourceBuilder sourceBuilder = new SearchSourceBuilder();
Iterator<Entry<String, Object>> itr = searchData.entrySet().iterator();
while (itr.hasNext()) {
Expand Down